-
Notifications
You must be signed in to change notification settings - Fork 18.9k
Rename AP::ahrs().get_roll() to AP::ahrs().get_roll_rad() etc. #30222
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rename AP::ahrs().get_roll() to AP::ahrs().get_roll_rad() etc. #30222
Conversation
f829d75
to
6dff5ec
Compare
singleton AP_AHRS method get_roll float | ||
singleton AP_AHRS method get_roll deprecate Use get_roll_rad |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
singleton AP_AHRS method get_roll deprecate Use get_roll_rad | |
singleton AP_AHRS method get_roll deprecate Use get_roll_rad or get_roll_deg |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done, thanks!
ad6f723
to
3d5208a
Compare
3d5208a
to
719084a
Compare
deprecate the old get_roll binding, make user choose between rad and deg
deprecate the old get_roll binding
719084a
to
fe28602
Compare
I've removed the _deg bindings and marking for merge as discussed at DevCall. I brought up the fact that you can get degs trivially, and that the flash cost for _deg bindings is real and permanent... so we decided to nix them for now. @IamPete1 there was the question as to whether we could add custom bindings for |
Costs more bytes on boards with scripting because of the extra bindings
Changes all the scripts to choose between renaming to use the new binding or use the other new binding introduced,
get_roll_deg
etc. Most places change to use_deg
Deprecates the old
get_roll
etc bindings, so at some stage that space can be reclaimed.If scripting is disabled then this is a no-compiler-output change. To that end, reviews could probably focus on the LUA script changes.