Skip to content

Added range check for parameters ACRO_BAL_PITCH, ACRO_BAL_ROLL and PILOT_SPEED_UP #30176

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

Lqs66
Copy link

@Lqs66 Lqs66 commented May 27, 2025

Fixed #30152.

Fixed #30177

@rmackay9
Copy link
Contributor

Hi @Lqs66,

Thanks for the PR. One small request, could you update the commit title to be prefixed with "Copter: "? E.g. "Copter: range check for ACRO_BAL_PITCH and ACRO_BAL_ROLL". If you peek at our commit history you'll see that we always prefix our commits with the subsystem or folder affected because this makes backporting easier. to be clear, I mean the commit title, not the PR title.

Txs!

@Lqs66
Copy link
Author

Lqs66 commented May 27, 2025

Hi @Lqs66,

Thanks for the PR. One small request, could you update the commit title to be prefixed with "Copter: "? E.g. "Copter: range check for ACRO_BAL_PITCH and ACRO_BAL_ROLL". If you peek at our commit history you'll see that we always prefix our commits with the subsystem or folder affected because this makes backporting easier. to be clear, I mean the commit title, not the PR title.

Txs!

Hi, I have made the requested changes.

@peterbarker
Copy link
Contributor

Closes #30152

@Lqs66 Lqs66 changed the title Added range check for parameters ACRO_BAL_PITCH and ACRO_BAL_ROLL in ACRO mode Added range check for parameters ACRO_BAL_PITCH, ACRO_BAL_ROLL and PILOT_SPEED_UP May 27, 2025
@rmackay9
Copy link
Contributor

One of the concerns of adding these checks is the flash cost. So this particular change costs 96 bytes it seems

Binary Name      Text [B]       Data [B]     BSS (B)      Total Flash Change [B] (%)      Flash Free After PR (B)
---------------  -------------  -----------  -----------  ----------------------------  -------------------------
blimp            0 (0.0000%)    0 (0.0000%)  0 (0.0000%)  0 (0.0000%)                                      741612
antennatracker   0 (0.0000%)    0 (0.0000%)  0 (0.0000%)  0 (0.0000%)                                      761904
ardusub          0 (0.0000%)    0 (0.0000%)  0 (0.0000%)  0 (0.0000%)                                      517292
arduplane        0 (0.0000%)    0 (0.0000%)  0 (0.0000%)  0 (0.0000%)                                      342768
ardurover        0 (0.0000%)    0 (0.0000%)  0 (0.0000%)  0 (0.0000%)                                      473236
arducopter       96 (+0.0059%)  0 (0.0000%)  0 (0.0000%)  96 (+0.0059%)                                    328120
arducopter-heli  96 (+0.0059%)  0 (0.0000%)  0 (0.0000%)  96 (+0.0059%)                                    329552```

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants