Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate geometry_msgs/PoseStampedArray to nav_msgs/Goals #4980

Open
wants to merge 8 commits into
base: main
Choose a base branch
from

Conversation

leander-dsouza
Copy link


Basic Info

Info Please fill out this column
Ticket(s) this addresses #4976
Primary OS tested on Ubuntu
Robotic platform tested on N/A
Does this PR contain AI generated software? No

Description of contribution in a few bullet points

  • Migrated geometry_msgs/msg/PoseStampedArray to nav_msgs/msg/Goals across the codebase.

Description of documentation updates required from your changes

  • The migration guide from Jazzy to Kilted needs to be updated for BT Nodes to use nav_msgs/msg/Goals instead.

Description of how this change was tested

  • Syntax migration tested through a simple colcon build from the workspace.
  • Unit tests were run using colcon test.

Future work that may be required in bullet points

For Maintainers:

  • Check that any new parameters added are updated in docs.nav2.org
  • Check that any significant change is added to the migration guide
  • Check that any new features OR changes to existing behaviors are reflected in the tuning guide
  • Check that any new functions have Doxygen added
  • Check that any new features have test coverage
  • Check that any new plugins is added to the plugins page
  • If BT Node, Additionally: add to BT's XML index of nodes for groot, BT package's readme table, and BT library lists

@leander-dsouza leander-dsouza changed the title Migrate geometry_msgs/msg/PoseStampedArray to nav_msgs/msg/Goals Migrate geometry_msgs/PoseStampedArray to nav_msgs/Goals Mar 11, 2025
@leander-dsouza leander-dsouza marked this pull request as ready for review March 11, 2025 22:47
@leander-dsouza leander-dsouza marked this pull request as draft March 11, 2025 23:15
@SteveMacenski
Copy link
Member

Check CI - a few tests failed with legit problems that a couple of spots were missed 😄

Copy link

codecov bot commented Mar 12, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Files with missing lines Coverage Δ
...avior_tree/include/nav2_behavior_tree/bt_utils.hpp 100.00% <100.00%> (ø)
...ugins/action/compute_path_through_poses_action.hpp 100.00% <100.00%> (ø)
...e/plugins/action/navigate_through_poses_action.hpp 100.00% <100.00%> (ø)
...lugins/action/remove_in_collision_goals_action.hpp 100.00% <100.00%> (ø)
...tree/plugins/action/remove_passed_goals_action.hpp 100.00% <100.00%> (ø)
...gins/condition/globally_updated_goal_condition.hpp 100.00% <100.00%> (ø)
..._tree/plugins/condition/goal_updated_condition.hpp 100.00% <100.00%> (ø)
...tree/plugins/decorator/goal_updated_controller.hpp 100.00% <100.00%> (ø)
...avior_tree/plugins/decorator/goal_updater_node.hpp 100.00% <100.00%> (ø)
...havior_tree/plugins/decorator/speed_controller.hpp 100.00% <100.00%> (ø)
... and 9 more

... and 6 files with indirect coverage changes

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@leander-dsouza
Copy link
Author

Check CI - a few tests failed with legit problems that a couple of spots were missed 😄

It should be fixed now :)
I had not migrated nav2_system_tests earlier to have the new message.

@leander-dsouza leander-dsouza marked this pull request as ready for review March 12, 2025 01:16
Copy link
Member

@SteveMacenski SteveMacenski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@tonynajjar this is your feature, can you validate that this works for you too? I did the code review and have no notes. I think its ready to go in once you're OK with it.

It just changes the name of the message essentially (and poses to goals) as Tully moved it to nav_msgs to be more semantically meaningful

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Convert geometry_msgs/msg/PoseStampedArray to nav_msgs/msg/Goals
2 participants