-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Migrate geometry_msgs/PoseStampedArray
to nav_msgs/Goals
#4980
base: main
Are you sure you want to change the base?
Migrate geometry_msgs/PoseStampedArray
to nav_msgs/Goals
#4980
Conversation
9fad256
to
71e1ce2
Compare
geometry_msgs/msg/PoseStampedArray
to nav_msgs/msg/Goals
geometry_msgs/PoseStampedArray
to nav_msgs/Goals
Check CI - a few tests failed with legit problems that a couple of spots were missed 😄 |
Signed-off-by: Leander Stephen D'Souza <[email protected]>
Signed-off-by: Leander Stephen D'Souza <[email protected]>
Signed-off-by: Leander Stephen D'Souza <[email protected]>
Signed-off-by: Leander Stephen D'Souza <[email protected]>
Signed-off-by: Leander Stephen D'Souza <[email protected]>
Signed-off-by: Leander Stephen D'Souza <[email protected]>
… to nav_msg goal. Signed-off-by: Leander Stephen D'Souza <[email protected]>
Signed-off-by: Leander Stephen D'Souza <[email protected]>
2748263
to
79b738f
Compare
It should be fixed now :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@tonynajjar this is your feature, can you validate that this works for you too? I did the code review and have no notes. I think its ready to go in once you're OK with it.
It just changes the name of the message essentially (and poses
to goals
) as Tully moved it to nav_msgs
to be more semantically meaningful
Basic Info
Description of contribution in a few bullet points
geometry_msgs/msg/PoseStampedArray
tonav_msgs/msg/Goals
across the codebase.Description of documentation updates required from your changes
nav_msgs/msg/Goals
instead.Description of how this change was tested
colcon build
from the workspace.colcon test
.Future work that may be required in bullet points
For Maintainers: