Switch from geometry_msgs/PoseStampedArray to nav_msgs/Goals #4983
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Tully Foote <[email protected]>
Signed-off-by: Tully Foote <[email protected]>
Signed-off-by: Tully Foote <[email protected]>
Signed-off-by: Tully Foote <[email protected]>
Signed-off-by: Tully Foote <[email protected]>
…es to .goals Signed-off-by: Tully Foote <[email protected]>
Signed-off-by: Tully Foote <[email protected]>
Signed-off-by: Tully Foote <[email protected]>
Signed-off-by: Tully Foote <[email protected]>
Signed-off-by: Tully Foote <[email protected]>
Signed-off-by: Tully Foote <[email protected]>
|
@tfoote, your PR has failed to build. Please check CI outputs and resolve issues. |
Signed-off-by: Tully Foote <[email protected]>
|
I hadn't, this was a backlog thing I'm trying to get out before I go off the grid and I'm already mostly disconnected. I'm happy to defer to that implementation. |
|
@tfoote, your PR has failed to build. Please check CI outputs and resolve issues. |
|
Great, I appreciate the follow up on this! Have a good time off the grid! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a follow on to ros2/common_interfaces#269
And is blocking ros2/common_interfaces#270
I've done my best to replicate the changes in: #4791
As this is a code base that I'm not familiar with I suspect that it won't be perfect as I haven't had a chance to iterate or test at all.
I think that there's one tweak to resort includes with the new name in places. I suspect that the linter will error on that.
Unfortunately I'm going to have to submit this and won't have time for significant followups as I'm going on leave for the next two weeks and I think that we don't want to wait that long to resolve this. @ahcorde maybe you can take a look to help get this across the line and unblock 270 above.