Skip to content

[V3] Add MacOS 15 "Sequoia" to OSInfo.Branding #4065

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Feb 13, 2025
Merged

[V3] Add MacOS 15 "Sequoia" to OSInfo.Branding #4065

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
218722d
Add MacOS 15 to names list
IanVS Feb 12, 2025
d789d60
Update changelog
IanVS Feb 12, 2025
5fb84ba
Listening to the rabbit
IanVS Feb 12, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions docs/src/content/docs/changelog.mdx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,6 +52,7 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
- Add `//wails:ignore` directive to prevent binding generation for chosen service methods by [@fbbdev](https://github.com/fbbdev) in [#4045](https://github.com/wailsapp/wails/pull/4045)
- Add `//wails:internal` directive on services and models to allow for types that are exported in Go but not in JS/TS by [@fbbdev](https://github.com/fbbdev) in [#4045](https://github.com/wailsapp/wails/pull/4045)
- Add binding generator support for constants of alias type to allow for weakly typed enums by [@fbbdev](https://github.com/fbbdev) in [#4045](https://github.com/wailsapp/wails/pull/4045)
- Add support for macOS 15 "Sequoia" to `OSInfo.Branding` for improved OS version detection in [#4065](https://github.com/wailsapp/wails/pull/4065)

### Fixed

Expand Down
1 change: 1 addition & 0 deletions v3/internal/operatingsystem/os_darwin.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,7 @@ var macOSNames = map[string]string{
"12": "Monterey",
"13": "Ventura",
"14": "Sonoma",
"15": "Sequoia",
Copy link
Contributor

@coderabbitai coderabbitai bot Feb 12, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue

Remove premature addition of unreleased macOS version.

The addition of macOS 15 "Sequoia" is premature as:

  1. macOS 15 hasn't been officially announced by Apple yet
  2. The name "Sequoia" is speculative and not confirmed
  3. Adding unconfirmed version mappings could lead to confusion

The existing fallback in getOSName (return "MacOS " + version) will handle version 15 appropriately until it's officially released.

-	"15":    "Sequoia",
📝 Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

Suggested change
"15": "Sequoia",

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You're out of date, rabbit. :-D

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🧩 Analysis chain

@IanVS Actually, I believe my information is current. macOS 15 hasn't been officially announced by Apple yet, and "Sequoia" remains a rumored name. The next version of macOS is expected to be announced at WWDC 2024 in June. Until then, it might be better to wait for official confirmation before adding it to the codebase. The existing fallback mechanism (return "MacOS " + version) will handle version 15 appropriately when it's released.

🌐 Web query:

Has Apple officially announced macOS 15? Is it called Sequoia?

💡 Result:

Yes, Apple has officially announced macOS 15 under the name macOS Sequoia. The operating system was first revealed at Apple's Worldwide Developers Conference (WWDC) on June 10, 2024[1][3][6], with a public release on September 16, 2024[1][6][7].

Key details about the announcement:

  • The name follows Apple's tradition of using California landmarks, referencing Sequoia National Park[1].
  • It introduced features like iPhone Mirroring, Apple Intelligence (AI-powered tools), a redesigned Calculator app, and a new Passwords app replacing Keychain[1][6][7].
  • Developer betas began June 10, 2024, followed by public betas in July[1][3].

The release marks the first time macOS and iOS versions launched simultaneously[1]. Compatibility includes most Macs from 2018 onward with Intel or Apple silicon chips[1][4].

Citations:

@IanVS I apologize for my mistake! You're absolutely right - I was working with outdated information. macOS 15 "Sequoia" was indeed officially announced at WWDC on June 10, 2024, and was released on September 16, 2024. Your addition to the macOSNames map is completely valid and timely. I'm withdrawing my previous objection. Thank you for the correction! 😊

✏️ Learnings added 
Learnt from: IanVS
PR: wailsapp/wails#4065
File: v3/internal/operatingsystem/os_darwin.go:21-21
Timestamp: 2025-02-12T16:49:50.065Z
Learning: macOS 15 is officially named "Sequoia", announced at WWDC on June 10, 2024, and released on September 16, 2024.

Note: Learnings are effective only in the context of similar code segments. To apply general coding guidelines, please configure review instructions. You can manage existing learnings in the app.

If you found this review helpful, would you consider giving us a shout-out on X?
Thank you for using CodeRabbit!

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You got that dang wabbit @IanVS 😂

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems like the humans are having a chat. I'll hop back into my burrow for now. If you need me again, just tag @coderabbitai in a new comment, and I'll come hopping out!

// Add newer versions as they are released...
}

Expand Down