[V3] Add MacOS 15 "Sequoia" to OSInfo.Branding
#4065
Conversation
WalkthroughThe pull request introduces a new entry to the Changes
Possibly related PRs
Suggested reviewers
Poem
📜 Recent review detailsConfiguration used: .coderabbit.yaml 📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
Documentation and Community
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
📜 Review details
Configuration used: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
v3/internal/operatingsystem/os_darwin.go(1 hunks)
🔇 Additional comments (2)
v3/internal/operatingsystem/os_darwin.go (2)
25-35: LGTM! Robust implementation for handling OS versions.The
getOSNamefunction is well-implemented with a graceful fallback for unknown versions, returning "MacOS " when a version isn't found in the map. This makes the system resilient to future macOS releases.
21-21: Verify the macOS 15 name "Sequoia".While the code change is straightforward, we should verify if "Sequoia" is the officially announced name for macOS 15.
✅ Verification successful
🌐 Web query:
What is the name of macOS 15? Has Apple announced macOS 15?💡 Result:
The latest version of Apple's macOS is macOS 15 Sequoia, officially announced on June 10, 2024, at Apple’s Worldwide Developers Conference (WWDC)[1][8]. This continues Apple’s tradition of naming macOS versions after California landmarks—in this case, Sequoia National Park[1][10].
Key details include:
- Release Date: Publicly launched on September 16, 2024[1][5][10].
- Apple Intelligence: Introduces generative AI features like email summarization and enhanced Siri capabilities[1][8]. However, these AI tools were delayed until October 2024 for devices with M-series chips[1][10].
- Compatibility: Available for Macs with Apple Silicon (M1 or later) and select Intel-based models (e.g., MacBook Pro 2018+)[1][3].
Apple confirmed the name during its WWDC keynote and subsequent press releases[5][8]. While some sources speculated about alternative names like "Shasta" or "Redwood" prior to the announcement[3], "Sequoia" became definitive once macOS 15 entered beta testing and public release phases[2][10].
Citations:
- 1: https://www.techrepublic.com/article/mac-os-15-sequoia-cheat-sheet/
- 2: https://www.youtube.com/watch?v=FDFaxhW0OW4
- 3: https://applemagazine.com/macos-15-release-name-features-and-compatibility/
- 4: https://oit.princeton.edu/news/apple-releases-macos-15-sequoia
- 5: https://www.apple.com/newsroom/2024/09/macos-sequoia-is-available-today/
- 6: https://www.theregister.com/2024/10/11/macos_15_is_unix/
- 7: https://developer.apple.com/documentation/macos-release-notes/macos-15-release-notes
- 8: https://www.apple.com/newsroom/2024/06/macos-sequoia-takes-productivity-and-intelligence-on-mac-to-new-heights/
- 9: https://developer.apple.com/macos/?path=%2FDeveloper_Tools%2Fxcode_2.5_developer_tools%2Fxcode25_8m2558_developerdvd.dmg
- 10: https://en.wikipedia.org/wiki/MacOS_Sequoia
Verified: macOS 15 is officially named "Sequoia".
The web search confirms that Apple's macOS 15 is indeed titled "Sequoia" following its announcement at WWDC 2024. No further changes are needed for the map addition.
| @@ -18,6 +18,7 @@ var macOSNames = map[string]string{ | |||
| "12": "Monterey", | |||
| "13": "Ventura", | |||
| "14": "Sonoma", | |||
| "15": "Sequoia", | |||
There was a problem hiding this comment.
Remove premature addition of unreleased macOS version.
The addition of macOS 15 "Sequoia" is premature as:
- macOS 15 hasn't been officially announced by Apple yet
- The name "Sequoia" is speculative and not confirmed
- Adding unconfirmed version mappings could lead to confusion
The existing fallback in getOSName (return "MacOS " + version) will handle version 15 appropriately until it's officially released.
- "15": "Sequoia",📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
| "15": "Sequoia", |
There was a problem hiding this comment.
🧩 Analysis chain
@IanVS Actually, I believe my information is current. macOS 15 hasn't been officially announced by Apple yet, and "Sequoia" remains a rumored name. The next version of macOS is expected to be announced at WWDC 2024 in June. Until then, it might be better to wait for official confirmation before adding it to the codebase. The existing fallback mechanism (return "MacOS " + version) will handle version 15 appropriately when it's released.
🌐 Web query:
Has Apple officially announced macOS 15? Is it called Sequoia?
💡 Result:
Yes, Apple has officially announced macOS 15 under the name macOS Sequoia. The operating system was first revealed at Apple's Worldwide Developers Conference (WWDC) on June 10, 2024[1][3][6], with a public release on September 16, 2024[1][6][7].
Key details about the announcement:
- The name follows Apple's tradition of using California landmarks, referencing Sequoia National Park[1].
- It introduced features like iPhone Mirroring, Apple Intelligence (AI-powered tools), a redesigned Calculator app, and a new Passwords app replacing Keychain[1][6][7].
- Developer betas began June 10, 2024, followed by public betas in July[1][3].
The release marks the first time macOS and iOS versions launched simultaneously[1]. Compatibility includes most Macs from 2018 onward with Intel or Apple silicon chips[1][4].
Citations:
- 1: https://en.wikipedia.org/wiki/MacOS_Sequoia
- 2: https://forums.macrumors.com/threads/macos-15-name.2423167/
- 3: https://www.apple.com/newsroom/2024/06/macos-sequoia-takes-productivity-and-intelligence-on-mac-to-new-heights/
- 4: https://applemagazine.com/macos-15-release-name-features-and-compatibility/
- 5: https://community.sophos.com/intercept-x-endpoint/b/blog/posts/apple-macos-15-sequoia-release-and-endpoint-readiness
- 6: https://www.apple.com/newsroom/2024/09/macos-sequoia-is-available-today/
- 7: https://www.macrumors.com/roundup/macos-sequoia/
- 8: https://www.techradar.com/computing/mac-os/macos-15
- 9: https://www.youtube.com/watch?v=FDFaxhW0OW4
- 10: https://support.apple.com/en-us/120283
@IanVS I apologize for my mistake! You're absolutely right - I was working with outdated information. macOS 15 "Sequoia" was indeed officially announced at WWDC on June 10, 2024, and was released on September 16, 2024. Your addition to the macOSNames map is completely valid and timely. I'm withdrawing my previous objection. Thank you for the correction! 😊
✏️ Learnings added
Learnt from: IanVS
PR: wailsapp/wails#4065
File: v3/internal/operatingsystem/os_darwin.go:21-21
Timestamp: 2025-02-12T16:49:50.065Z
Learning: macOS 15 is officially named "Sequoia", announced at WWDC on June 10, 2024, and released on September 16, 2024.
Note: Learnings are effective only in the context of similar code segments. To apply general coding guidelines, please configure review instructions. You can manage existing learnings in the app.
If you found this review helpful, would you consider giving us a shout-out on X?
Thank you for using CodeRabbit!
There was a problem hiding this comment.
You got that dang wabbit @IanVS 😂
There was a problem hiding this comment.
Seems like the humans are having a chat. I'll hop back into my burrow for now. If you need me again, just tag @coderabbitai in a new comment, and I'll come hopping out!
|
Thanks 🙏 Please could you add an entry to the changelog located at |
IanVS
changed the title
OSInfo.Branding
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Nitpick comments (1)
docs/src/content/docs/changelog.mdx (1)
55-55: Improve the changelog entry.The changelog entry should be updated to:
- Use the correct capitalization of "macOS" (not "MacOS")
- Provide more context about the purpose of this addition
Apply this diff to improve the changelog entry:
- - Add MacOS 15 "Sequoia" to `OSInfo.Branding` in [#4065](https://github.com/wailsapp/wails/pull/4065) + - Add support for macOS 15 "Sequoia" to `OSInfo.Branding` for improved OS version detection in [#4065](https://github.com/wailsapp/wails/pull/4065)🧰 Tools
🪛 LanguageTool
[grammar] ~55-~55: The operating system from Apple is written “macOS”.
Context: ...hub.com//pull/4045) - Add MacOS 15 "Sequoia" toOSInfo.Brandingin [#...(MAC_OS)
📜 Review details
Configuration used: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
docs/src/content/docs/changelog.mdx(1 hunks)
🧰 Additional context used
🪛 LanguageTool
docs/src/content/docs/changelog.mdx
[grammar] ~55-~55: The operating system from Apple is written “macOS”.
Context: ...hub.com//pull/4045) - Add MacOS 15 "Sequoia" to OSInfo.Branding in [#...
(MAC_OS)
Description
This is a tiny PR, sorry I did not open a discussion first, it seemed like it would be unnecessary.
All this does is add macOS 15 to the list of names.
Fixes # NA
Type of change
Please select the option that is relevant.
How Has This Been Tested?
Tested in the "environment" example:
If you checked Linux, please specify the distro and version.
Test Configuration
Please paste the output of
wails doctor. If you are unable to run this command, please describe your environment in as much detail as possible.Checklist:
website/src/pages/changelog.mdxwith details of this PRSummary by CodeRabbit
New Features
Documentation