Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update smac planner types #4927

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

InvincibleRMC
Copy link


Basic Info

Info Please fill out this column
Primary OS tested on (Ubuntu)

Description of contribution in a few bullet points

I saw #4916 to add ament_mypy to type check. I noticed there were some errors raised by ament_mypy so i resolved the ones in nav2_smac_planner.

Description of how this change was tested

I ran ament_mypy nav2_smac_planner/ and got no errors.


For Maintainers:

  • Check that any new parameters added are updated in docs.nav2.org
  • Check that any significant change is added to the migration guide
  • Check that any new features OR changes to existing behaviors are reflected in the tuning guide
  • Check that any new functions have Doxygen added
  • Check that any new features have test coverage
  • Check that any new plugins is added to the plugins page
  • If BT Node, Additionally: add to BT's XML index of nodes for groot, BT package's readme table, and BT library lists

Signed-off-by: Michael Carlstrom <[email protected]>
Copy link

codecov bot commented Feb 17, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

see 3 files with indirect coverage changes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant