Add a fixedheader ad style #218
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Pinned ad type at the top of the page. Supports text-only or image+text, but hidden on mobile. - Much heavier use of CSS variables - Because there's some duplication in defining colors twice, this does add a bit of size ~8kb minified to the ad client.
ericholscher
approved these changes
Feb 25, 2025
There was a problem hiding this comment.
Would probably be useful to get @agjohnson review on the CSS as well, but I took a quick look at it.
|
|
||
| <!-- Place this div just after the open <body> tag (top of the document) --> | ||
| <!-- You can also use `data-ea-type="text"` for a text-only ad --> | ||
| <!-- Set style="height 50px" to preallocate space for the ad --> |
There was a problem hiding this comment.
Suggested change
| <!-- Set style="height 50px" to preallocate space for the ad --> | |
| <!-- Set style="height: 50px" to preallocate space for the ad --> |
I think this is right. But we should probably include this in the default example below, right?
There was a problem hiding this comment.
Ya, maybe mention that it should either be here or via CSS.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PinnedAd type at the top of the page. Supports text-only or image+text, but hidden on mobile. It is not pinned. Users can just scroll past it.