Use CSS properties everywhere #219
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Use styles in our CSS - Document styles in the docs
ericholscher
approved these changes
Feb 24, 2025
There was a problem hiding this comment.
Just a note that since the ad client styles are injected into the head, they will take precedence over something a publisher puts in their CSS file (eg. if they put something like [data-ea-publisher] { --ea-color-domain: black; } in their main.css). They can use !important or they can inline the style (
). Perhaps we should change this?
Does that mean this will break publishers styling if we ship it? If so, we should try to find a way to make it backwards compatible in some fashion.
No. Any existing styling publishers have should work. What I'm saying is that overriding is a little tricky but not trickier than it was before. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is branched and based off #218.
Just a note that since the ad client styles are injected into the head, they will take precedence over something a publisher puts in their CSS file (eg. if they put something like
[data-ea-publisher] { --ea-color-domain: black; }in theirmain.css). They can use!importantor they can inline the style (<div style="--ea-color-domain: black" data-ea-publisher="...">). Perhaps we should change this?