-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
リンクタイプ決済の取引取消機能を追加する #114
リンクタイプ決済の取引取消機能を追加する #114
Conversation
91d7858
to
97bc683
Compare
@@ -37,6 +37,15 @@ def purchase(amount, detail = {}) | |||
|
|||
commit('receive_order3.cgi', params, RESPONSE_KEYS) | |||
end | |||
|
|||
def cancel_purchase(order_number) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
決済の取消になるのでメソッド名 void
でもいいかなと思いました(他のイプシロンの決済と使用感を揃えるためにも)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
他のイプシロン決済に併せてメソッド名を void
に変更しました。
READMEにも追加した方がよさそうかと〜 例: https://github.com/pepabo/active_merchant-epsilon#void-transaction |
今回追加したメソッドをREADMEにも追加しました。 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
対応ありがとうございます。LGTM 🌟
レビューありがとうございました。 |
やったこと
void
を追加する参考:
イプシロン決済システム仕様書 Ver.1.0.42 p74