Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

リンクタイプ決済の取引取消機能を追加する #114

Merged
merged 7 commits into from
Jul 22, 2020

Conversation

yuriko1211
Copy link
Contributor

@yuriko1211 yuriko1211 commented Jul 15, 2020

やったこと

  • リンクタイプ決済の取引取消CGIを叩くメソッド voidを追加する
  • リンクタイプ決済のテストを追加
  • READMEにリンクタイプ決済の取引取消についての記載を追加

参考: イプシロン決済システム仕様書 Ver.1.0.42 p74

@yuriko1211 yuriko1211 changed the title [WIP]リンクタイプ決済の取引取消機能を追加する リンクタイプ決済の取引取消機能を追加する Jul 15, 2020
@yuriko1211 yuriko1211 force-pushed the add-cancel-purchase-for-link-type branch from 91d7858 to 97bc683 Compare July 15, 2020 07:53
@yuriko1211 yuriko1211 requested a review from ksbmyk July 15, 2020 08:03
@@ -37,6 +37,15 @@ def purchase(amount, detail = {})

commit('receive_order3.cgi', params, RESPONSE_KEYS)
end

def cancel_purchase(order_number)
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

決済の取消になるのでメソッド名 void でもいいかなと思いました(他のイプシロンの決済と使用感を揃えるためにも)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

他のイプシロン決済に併せてメソッド名を void に変更しました。

8a457cb

@ksbmyk
Copy link

ksbmyk commented Jul 16, 2020

READMEにも追加した方がよさそうかと〜 例: https://github.com/pepabo/active_merchant-epsilon#void-transaction

@yuriko1211
Copy link
Contributor Author

今回追加したメソッドをREADMEにも追加しました。

f88ab69

@yuriko1211 yuriko1211 requested a review from ksbmyk July 20, 2020 03:09
Copy link

@ksbmyk ksbmyk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

対応ありがとうございます。LGTM 🌟

@yuriko1211
Copy link
Contributor Author

レビューありがとうございました。
マージします。

@yuriko1211 yuriko1211 merged commit 313faa1 into master Jul 22, 2020
@yuriko1211 yuriko1211 deleted the add-cancel-purchase-for-link-type branch July 22, 2020 03:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants