Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump up version 0.11.0 #115

Merged
merged 3 commits into from
Jul 27, 2020
Merged

Bump up version 0.11.0 #115

merged 3 commits into from
Jul 27, 2020

Conversation

yuriko1211
Copy link
Contributor

#114 でイプシロンリンクタイプ決済の取消しを行う void メソッドを追加しました。

@yuriko1211 yuriko1211 requested review from ku00 and removed request for ku00 July 22, 2020 03:55
Copy link
Contributor

@ku00 ku00 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

コメントしました

@@ -1,5 +1,9 @@
# CHANGELOG

### 0.10.1

- [Add void mehotd for Epsilon Link Payment](https://github.com/pepabo/active_merchant-epsilon/pull/114)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

機能追加なのでパッチバージョンではなくマイナーバージョンを上げるのが良いかと思いましたがどうでしょうか

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

おっしゃる通りマイナーバージョンを上げる方が良さそうなので修正しました。
2361563

PRのタイトルも合わせて修正しました。

@yuriko1211 yuriko1211 changed the title Bump up version 0.10.1 Bump up version 0.11.0 Jul 22, 2020
@yuriko1211 yuriko1211 requested a review from ku00 July 22, 2020 07:50
Copy link
Contributor

@ku00 ku00 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@ryuchan00 ryuchan00 merged commit 13424cb into master Jul 27, 2020
@kenchan kenchan deleted the version-0.10.1 branch May 19, 2024 06:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants