[kilted] Update deprecated call to ament_target_dependencies #3467
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Alejandro Hernandez Cordero <[email protected]>
|
Related PR MetroRobotsForks#1 which should fix the build |
Fixed ament_target_dependencies
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3467 +/- ##
==========================================
- Coverage 46.23% 0.00% -46.22%
==========================================
Files 718 94 -624
Lines 62677 11663 -51014
Branches 7583 1866 -5717
==========================================
- Hits 28975 0 -28975
+ Misses 33535 11663 -21872
+ Partials 167 0 -167 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
rhaschke
reviewed
Jun 12, 2025
| collision_detector_bullet_plugin moveit_collision_detection_bullet | ||
| moveit_planning_scene moveit_utils) | ||
| collision_detector_bullet_plugin | ||
| PUBLIC ${BULLET_LIBRARIES} |
There was a problem hiding this comment.
Here (and probably in many other places too), the plugin should just depend on its base lib (moveit_collision_detection_bullet). All other dependencies should be pulled in automatically in a transitive fashion.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As of the ROS 2 Kilted release
ament_target_dependenciesis deprecated.This PR updates the syntax. Caution should be used to ensure that the target branch is not used for other ROS 2 distros.
Note: This PR was generated by a bot script, but using the simple pattern matching of the
ros_glintlibrary. No LLMs were used.