Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add padding to edges of file list, and compensate spacing in details and grid #924

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Add padding to edges of file list, and compensate spacing in details and grid #924

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 4 additions & 11 deletions src/files-card-body.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -183,16 +183,16 @@

&.view-details {
--icon-size: 16px;
--pf-v5-c-table--m-compact--cell--first-last-child--PaddingLeft: var(--pf-v5-global--spacer--md);
--pf-v5-c-table--m-compact--cell--first-last-child--PaddingRight: var(--pf-v5-global--spacer--md);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would be nice to know where this exactly comes from, for when we try to look into PF6

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's in the table component, used in the cells, in the compact variant... according to the variable naming. As the component variables are defined in the toplevel component, that's where I changed it here (rather than lower in the stack).

inline-size: 100%;
margin: 0;


tbody tr {
border-block: 1px solid var(--pf-v5-global--BorderColor--100);
}

th, td {
padding: var(--pf-v5-global--spacer--sm);
border-block-start: none;
}

Expand All @@ -216,14 +216,6 @@
justify-content: end;
}
}

:first-child:is(td, th) {
padding-inline-start: var(--pf-v5-global--spacer--lg);
}

:last-child:is(td, th):not(.pf-v5-c-table__sort) {
padding-inline-end: var(--pf-v5-global--spacer--lg);
}
}

&.view-grid {
Expand All @@ -241,7 +233,7 @@
gap: var(--pf-v5-global--spacer--sm);
grid-template-columns: repeat(auto-fill, minmax(8rem,1fr));
justify-content: space-between;
margin: var(--pf-v5-global--spacer--sm);
padding-block-end: var(--pf-v5-global--spacer--sm);

tr {
border-radius: var(--pf-v5-global--BorderWidth--xl);
Expand Down Expand Up @@ -314,4 +306,5 @@
// so drag&drop works in empty space
.fileview-wrapper {
block-size: 100%;
padding-inline: var(--pf-v5-global--spacer--md);
}