Add padding to edges of file list, and compensate spacing in details and grid #924
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jelly
requested changes
Feb 3, 2025
| @@ -183,16 +183,16 @@ | |||
|
|
|||
| &.view-details { | |||
| --icon-size: 16px; | |||
| --pf-v5-c-table--m-compact--cell--first-last-child--PaddingLeft: var(--pf-v5-global--spacer--md); | |||
| --pf-v5-c-table--m-compact--cell--first-last-child--PaddingRight: var(--pf-v5-global--spacer--md); | |||
There was a problem hiding this comment.
Would be nice to know where this exactly comes from, for when we try to look into PF6
There was a problem hiding this comment.
It's in the table component, used in the cells, in the compact variant... according to the variable naming. As the component variables are defined in the toplevel component, that's where I changed it here (rather than lower in the stack).
I don't think it does code-wise, even if it does show up visually. It's probably just that it's more visible now instead. Perhaps I changed margin to 0 instead of -1px or something like that. But, yeah, we should fix it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Mostly fixes #787 by adding a bit of padding around the list (and trimming some spacing inside the details and grid views).
However, it'd probably also be a good idea to show the folder's context menu when you right click the grey background gutter area.