Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PMM-12153 Upgrade mysqld_exporter #3833

Draft
wants to merge 11 commits into
base: v3
Choose a base branch
from
4 changes: 3 additions & 1 deletion ci.py
Original file line number Diff line number Diff line change
Expand Up @@ -232,9 +232,11 @@ def check_deps(self):
else:
target_url = next(item for item in self.config['deps'] if item["name"] == dep['name'])['url']
repo_path = '/'.join(target_url.split('/')[-2:])
target_branch = dep['branch']
if '.git' in repo_path:
Copy link
Member Author

@ademidoff ademidoff Jan 27, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Without this, the build would fail with a 404 not being able to find the repository in case it's name ends with '.git'.

repo_path = repo_path.replace('.git', '')
repo = github_api.get_repo(repo_path)
org = repo.organization.name if repo.organization else repo.owner.login
target_branch = dep['branch']
head = f'{org}:{target_branch}'
pulls_list = repo.get_pulls('open', 'updated', 'asc', 'main', head)
if not pulls_list.totalCount:
Expand Down
7 changes: 7 additions & 0 deletions ci.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
deps:
- name: mysqld_exporter
branch: PMM-12153-upgrade-mysql-exporter
url: https://github.com/percona/mysqld_exporter
- name: pmm
branch: PMM-12153-upgrade-mysql-exporter
url: https://github.com/percona/pmm
Loading