Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PMM-12153 Upgrade mysqlq_exporter #3833

Draft
wants to merge 2 commits into
base: v3
Choose a base branch
from
Draft

PMM-12153 Upgrade mysqlq_exporter #3833

wants to merge 2 commits into from
+7 −1

Conversation

ademidoff
Copy link
Member

ademidoff
ademidoff commented Jan 27, 2025
View reviewed changes
ci.py
@@ -232,6 +232,8 @@ def check_deps(self):
else:
target_url = next(item for item in self.config['deps'] if item["name"] == dep['name'])['url']
repo_path = '/'.join(target_url.split('/')[-2:])
if '.git' in repo_path:
Copy link
Member Author

@ademidoff ademidoff Jan 27, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Without this, the build would fail with a 404 not being able to find the repository in case it's name ends with '.git'.

@ademidoff ademidoff force-pushed the PMM-12153-upgrade-mysql-exporter branch from 75d9ed3 to e535ea8 Compare February 5, 2025 07:57
@JNKPercona
Copy link
Collaborator

Server docker: perconalab/pmm-server-fb:PR-3833-010f5cc
Client docker: perconalab/pmm-client-fb:PR-3833-010f5cc
Watchtower docker: perconalab/pmm-watchtower-fb:PR-3833-010f5cc
Client tarball: https://s3.us-east-2.amazonaws.com/pmm-build-cache/PR-BUILDS/pmm-client/pmm-client-PR-3833-010f5cc.tar.gz
Staging instance: https://pmm.cd.percona.com/job/pmm3-aws-staging-start/parambuild/?DOCKER_VERSION=perconalab/pmm-server-fb:PR-3833-010f5cc&CLIENT_VERSION=https://s3.us-east-2.amazonaws.com/pmm-build-cache/PR-BUILDS/pmm-client/pmm-client-PR-3833-010f5cc.tar.gz

@JNKPercona
Copy link
Collaborator

API tests have succeded: https://pmm.cd.percona.com/job/pmm3-api-tests/1869/

@Percona-Lab Percona-Lab deleted a comment from JNKPercona Feb 5, 2025
@Percona-Lab Percona-Lab deleted a comment from JNKPercona Feb 5, 2025
@Percona-Lab Percona-Lab deleted a comment from JNKPercona Feb 5, 2025
@Percona-Lab Percona-Lab deleted a comment from JNKPercona Feb 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@talhabinrizwan talhabinrizwan Awaiting requested review from talhabinrizwan talhabinrizwan will be requested when the pull request is marked ready for review talhabinrizwan is a code owner

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ademidoff @JNKPercona