[17.0][MIG] project_role: Migration to 17.0

[ramiadavid]

No description provided.

[ramiadavid]

@xavierboes updated

[xavierboes]

Further testing: the project is not visible when opening the Assignment list (view: project_role.project_assignment_tree).
Would leave out the invisible condition (invisible="context.get('default_project_id', False)").

Also, why not add the assignments as a tab/page on the project?

            <notebook position="inside">
                <page name="assignments" string="Assignments">
                    <field name="assignment_ids">
                        <tree>
                            <field name="role_id"/>
                            <field name="user_id"/>
                        </tree>
                    </field>
                </page>
            </notebook>

[ramiadavid]

@xavierboes

the project is not visible when opening the Assignment list (view: project_role.project_assignment_tree).

I'm sorry, but I don't see where the project is not visible, I can see it, can you show me a screenshot?

Also, why not add the assignments as a tab/page on the project?

I think we should do this as an improvement, to be able to forward to other versions, instead of doing it in the migration, what do you think?

[xboes]

@ramiadavid Project is now visible, seems fixed ✅

[xavierboes]

@ramiadavid : project visibility is still incorrect.

Problem is here:

<field name="project_id" domain="[('active', '=', True)]" invisible="context.get('default_project_id', False)"/>

Resulting in empty list view:

--> Would leave out the "invisible" statement.

Also, would really appreciate the tab/page addition as it improves workability from functional standpoint

[ramiadavid]

@xavierboes Updated

[xboes]

Great, LGTM !

[gbtechnology]

Hello, who should merge this?

[pedrobaeza]

/ocabot migration project_role

2 reviews should be done:

https://github.com/OCA/odoo-community.org/blob/master/website/Contribution/CONTRIBUTING.rst#review

[alexey-pelykh]

Isn't this a new feature?

[CasVissers-360ERP]

Functional review

[coleste]

👍
what is happening with the new feature?

[dreispt]

/ocabot merge nobump

[OCA-git-bot]

On my way to merge this fine PR!
Prepared branch 17.0-ocabot-merge-pr-1204-by-dreispt-bump-nobump, awaiting test results.

[OCA-git-bot]

Congratulations, your PR was merged at f4519bb. Thanks a lot for contributing to OCA. ❤️