Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[18.0][MIG] project_role #1378

Merged
merged 27 commits into from
Feb 9, 2025
Merged

[18.0][MIG] project_role #1378

merged 27 commits into from
Feb 9, 2025

Conversation

astirpe
Copy link
Member

@astirpe astirpe commented Nov 24, 2024 •
edited
Loading

Porting from #1204

@astirpe astirpe force-pushed the 18_mig_project_role branch 2 times, most recently from 3da6507 to d9a5f54 Compare November 24, 2024 16:14
@astirpe astirpe marked this pull request as ready for review November 24, 2024 16:16
coleste
coleste approved these changes Dec 5, 2024
View reviewed changes
Copy link

@coleste coleste left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, some minor linting changes

alexey-pelykh and others added 26 commits January 15, 2025 16:55
@alexey-pelykh @astirpe
[12.0][ADD] project_role: role-based project roster
7664ebe
@OCA-git-bot @astirpe
[ADD] icon.png
8f9b0ba
@alexey-pelykh @astirpe
[IMP] Don't allow create-and-edit on assignments
1e87486
@alexey-pelykh @astirpe
[IMP] Don't allow quick-create on assignments
b683379
@alexey-pelykh @astirpe
[IMP] project_role: improve usability
6b2eee6
@alexey-pelykh @astirpe
[FIX] project_role: bad menu item
f665f8b
@alexey-pelykh @astirpe
[IMP] project_role: revert manual options in favor of web_m2x_options
00e6f81
@alexey-pelykh @astirpe
[IMP] project_role: hierarchy, archived roles and assignments
b84caf7
@alexey-pelykh @astirpe
[IMP] project_role: add maintainers
cdb6451
@alexey-pelykh @astirpe
[IMP] project_role: possible roles
118a366
@alexey-pelykh @astirpe
[FIX] project_role: missing migration
51343af
@alexey-pelykh @astirpe
[IMP] project_role: enhance API
85010a7
@astirpe
[IMP] project_role : black, isort, prettier
0ef36e7
@astirpe
[MIG] project_role: Migration to 13.0
137ed3a
@alexey-pelykh @astirpe
[UPD] Brainbean Apps => CorporateHub
ae75cb3 
[UPD] README.rst
@Yoshiro009 @astirpe
[MIG] project_role Migration to 14.0
afe49a3
@OCA-git-bot @astirpe
[IMP] update dotfiles [ci skip]
b219b2c
@alexey-pelykh @astirpe
[MIG] project_role: Migration to 15.0
e100354
@victoralmau @astirpe
[FIX] project_role: Add recursive=True parameter to complete_name fie…
939be79 
…ld to prevent error.
@leemannd @astirpe
[MIG] project_role: Migration to 16.0
183b485
@len-foss @astirpe
[IMP] project_role: inherit create in batch
fb095f2
@MiquelRForgeFlow @astirpe
[FIX] project_role: image_128 -> avatar_128
1b29057
@ramiadavid @astirpe
[IMP] project_role: Add unaccent=False to parent_path field
bb299cf
@ramiadavid @astirpe
[IMP] project_role: pre-commit auto fixes
a6d63d3
@ramiadavid @astirpe
[MIG] project_role: Migration to 17.0
be00cd1
@astirpe
[MIG] project_role: pre-commit
002bded
@astirpe astirpe force-pushed the 18_mig_project_role branch from d9a5f54 to f3773c0 Compare January 15, 2025 15:58
@astirpe astirpe marked this pull request as draft January 15, 2025 16:00
@astirpe astirpe marked this pull request as ready for review January 15, 2025 16:02
CasVissers-360ERP
CasVissers-360ERP approved these changes Jan 15, 2025
View reviewed changes
Copy link

@CasVissers-360ERP CasVissers-360ERP left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Functional review

@OCA-git-bot
Copy link
Contributor

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

@dreispt
Copy link
Member

dreispt commented Feb 9, 2025

/ocabot merge nobump
/ocabot migration project_role

@OCA-git-bot OCA-git-bot added this to the 18.0 milestone Feb 9, 2025
@OCA-git-bot
Copy link
Contributor

What a great day to merge this nice PR. Let's do it!
Prepared branch 18.0-ocabot-merge-pr-1378-by-dreispt-bump-nobump, awaiting test results.

@OCA-git-bot OCA-git-bot mentioned this pull request Feb 9, 2025
Open
12 tasks
@OCA-git-bot OCA-git-bot merged commit ffd8732 into OCA:18.0 Feb 9, 2025
5 checks passed
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at 723f107. Thanks a lot for contributing to OCA. ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dreispt dreispt dreispt approved these changes

@coleste coleste coleste approved these changes

@CasVissers-360ERP CasVissers-360ERP CasVissers-360ERP approved these changes

Assignees
No one assigned
Labels
approved merged 🎉 ready to merge
Projects
None yet
Milestone
18.0
Development

Successfully merging this pull request may close these issues.