Modified the _config_get function to properly handle nested YAML values. #845
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…lues. @todo: Move config import functions to parent class to consolidate code.
@todo: Move config import functions to parent class to consolidate code.
…onfigGPT).
- Added `rgx_capture` variable to config file. Provide a regex string with capture group(s), provides customizable approach to filtering GPT response (concatenates multiple capture groups, if provided). (Default: capture all.)
- Improved `_config_get` to handle `n`-nested keys (e.g. `ollama.deepseek.rgx_capture`)
Revamping of `ollama.py`
- Removal of esoteric translation refusal handling and other such fixes.
- Made child class of ConfigGPT
- Use rgx_capture to filter output
- Added `OLLAMA_MODEL_CONF` variable to imported keys
- Due to `ollama` being an interface rather than a specific model, different config options are desirable depending on the model used. This additional key allows one to specify a sub-set of configs (e.g. `ollama.deepseek`, `ollama.llama`, etc.)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The OmegaConf's
getfunction does not appear to handle nested YAML values as expected.Instead of interpreting the value to the left of
.as the parent key, it seems to interpret it literally (e.g. searches for a key namedchatgpt.chat_system_template).The
selectfunction is able to handle nested values (and searches top-level keys with.if_CONFIG_KEYis empty). However, it will not search upward for thekey, and instead returnsNone, sogetis still required.ToDo: Move
gpt_configstuff to a parent class