use our fork of s3fs for upstream testing #3091
Open
+5
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
needs release notes
|
because the impact of this PR is narrowly scoped to a subsection of our CI, and it works at its intended purpose, I'd like to merge this soon and without release notes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
s3fsdepends on an exact version offsspec(2025.5.1). The unreleased version offsspec, i.e. what you get when you install fsspec from a git dependency declaration likefsspec @ git+https://github.com/fsspec/filesystem_spec, is generally ahead of that version, and thus the two are, by declaration, incompatible. This apparent incompatibility has prevented recent upstream tests from succeeding.As a short-term fix, I forked s3fs and relaxed the upper bound of its fsspec dependency. This PR changes the upstream tests s3fs dependency to use our fork.
this was discussed over at s3fs here