Partially revert #2810 #2849
Merged
Partially revert #2810 #2849
+48
−37
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hughcapet
added
the
architectural
hughcapet
force-pushed
the
fix/mainwindow-partial-revert
branch
2 times, most recently
from
f5f730e to
f66e30f
Compare
…GVERSION env change
hughcapet
force-pushed
the
fix/mainwindow-partial-revert
branch
from
f66e30f to
604b760
Compare
FxKu
reviewed
Jan 22, 2025
| @@ -1187,7 +1187,7 @@ def test_major_version_upgrade(self): | |||
| Test major version upgrade: with full upgrade, maintenance window, and annotation | |||
| """ | |||
| def check_version(): | |||
| p = k8s.patroni_rest("acid-upgrade-test-0", "") | |||
| p = k8s.patroni_rest("acid-upgrade-test-0", "") or {} | |||
There was a problem hiding this comment.
or {}?
I don't understand python sometimes
There was a problem hiding this comment.
it can return None and then p.get("server_version", 0) will break everything with exception
or {} returns empty dict instead of None
hughcapet
requested review from
sdudoladov,
Jan-M,
jopadi,
idanovinda and
macedigital
as code owners
FxKu
reviewed
Jan 23, 2025
hughcapet
force-pushed
the
fix/mainwindow-partial-revert
branch
from
5e0fc53 to
e78dbe6
Compare
|
👍 |
1 similar comment
|
👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Consider MaintenanceWindows only for pod migration