Skip to content

Changes to support htmlwidgets integration #86

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

dmurdoch
Copy link

@dmurdoch dmurdoch commented Apr 19, 2025

This PR changes two things:

  1. It changes mark() to allow meta to be specified as a chunk option. This will allow an htmlwidget record_print() method to insert dependencies.

I considered some other ways to do this:
a. Use the litedown.html.meta option. The problem with this is that there doesn't seem to be a way to restore that option at the end of the run, whereas fuse() does restore reactor() values.
b. Add a new function that code could use to set options. This seems unnecessarily complicated.
c. Use Javascript methods directly. The problem with this is that some dependencies could end up inserted multiple times.

  1. It changes gen_tag() so that a file dependency can be specified as an absolute path. That's how htmltools::resolveDependencies() will produce them.

It would be possible to convert those absolute paths to relative paths, but that seems kludgy.

This code works with the litedown branch of https://github.com/dmurdoch/htmlwidgets .

This allows code like htmlwidgets to modify it.
(so `htmlwidgets` can ask for recent changes).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant