Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix sass lighten function deprecation warning and update sass to latest version #812

Closed
wants to merge 1 commit into from
Closed

Fix sass lighten function deprecation warning and update sass to latest version #812

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 5 additions & 3 deletions example/app.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -79,7 +79,8 @@ label {

.video-wrapper {
position: relative;
padding: 33.35% 0; /* 16:9 */
padding: 33.35% 0;
/* 16:9 */
height: 0;
}

Expand Down Expand Up @@ -126,7 +127,7 @@ label {
margin: 10px 0;
}

.app-buttons li + li {
.app-buttons li+li {
padding: 0;
}

Expand All @@ -148,6 +149,7 @@ label {
}

@media (max-width: 1024px) {

.app .image-gallery,
.app-sandbox {
width: 100%;
Expand Down Expand Up @@ -199,4 +201,4 @@ input.app-interval-input {

.app-checkboxes li {
display: block;
}
}
4 changes: 2 additions & 2 deletions package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -72,7 +72,7 @@
"react-swipeable": "7.0.1",
"remove-files-webpack-plugin": "^1.4.5",
"resize-observer-polyfill": "^1.5.0",
"sass": "^1.35.2",
"sass": "^1.83.4",
"sass-loader": "^12.1.0",
"style-loader": "^2.0.0",
"url-loader": "^4.1.1",
Expand All @@ -84,4 +84,4 @@
"react": "^16.0.0 || ^17.0.0 || ^18.0.0"
},
"dependencies": {}
}
}
2 changes: 1 addition & 1 deletion src/components/ImageGallery.jsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,6 @@ import clsx from "clsx";
import React from "react";
import throttle from "lodash-es/throttle";
import debounce from "lodash-es/debounce";
import isEqual from "react-fast-compare";
import ResizeObserver from "resize-observer-polyfill";
import { LEFT, RIGHT, UP, DOWN } from "react-swipeable";
import { arrayOf, bool, func, number, oneOf, shape, string } from "prop-types";
Expand All @@ -14,6 +13,7 @@ import PlayPause from "src/components/controls/PlayPause";
import SwipeWrapper from "src/components/SwipeWrapper";
import TopNav from "src/components/controls/TopNav";
import BottomNav from "src/components/controls/BottomNav";
import { isEqual } from "lodash-es";

const screenChangeEvents = [
"fullscreenchange",
Expand Down
4 changes: 3 additions & 1 deletion styles/scss/image-gallery.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,11 +1,13 @@
@use "sass:color";

$ig-small-screen: 768px !default;
$ig-xsmall-screen: 480px !default;
$ig-white: #fff !default;
$ig-black: #000 !default;
$ig-blue: #337ab7 !default;
$ig-background-black: rgba(0, 0, 0, 0.4) !default;
$ig-transparent: rgba(0, 0, 0, 0) !default;
$ig-shadow: 0 2px 2px lighten($ig-black, 10%);
$ig-shadow: 0 2px 2px color.adjust($ig-black, $lightness: 10%);

@mixin vendor-prefix($name, $value) {
@each $vendor in ("-webkit-", "-moz-", "-ms-", "-o-", "") {
Expand Down
Loading
Loading