-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add dark theme #56
base: master
Are you sure you want to change the base?
Add dark theme #56
Conversation
Hello, I've looked into the issue after you mentioned and found this answer at stackoverflow. I was implementing the same thing, then saw already submitted a pull request. 👍 Things I miss are the undo-snackbar and renaming lists. You got that done too, or do I have to actually do this myself? 😁😂 |
I also noticed that you forgot to update the parent theme for AppDialogTheme and AppAlertTheme, causing TextInputDialogs to be barely readable. |
That should already be the case, I'm not sure why you're seeing something different?
I did undo snackbars in #55, but not renaming :) Regarding androidx: Great that you found the culprit!
Option 2) will be less work for everyone involved I think. In any case, I'll wait till @woefe signals that he has time to go through all of it. |
Not sure if he still maintains this repo? I'm just using your PR in my fork and added the renaming thing.
Yes, that would be the best I think. |
@woefe are you still maintaining this app? It has a lot of good feedback in terms of suggestions and PRs. If you don't have the time, perhaps please consider adding one of the contributors as admin so a new version can be released and published on F-Droid. |
Adds a dark theme, addressing #3.
Per default it will follow the system theme (on systems that support it, else be white).
This includes definitely Android Q and LineageOS 16, but possible others (Funny enough not OxygenOS even though OnePlus prides itself with being on the forefront of these things!).
Note that I bumped minSdkVersion to 21 (i.e. from KitKat to Lollipo) in order to set the colour of the up arrow in the toolbar (via the
android:colorControlNormal
attribute in thestyles.xml
. Hope it's okay to drop support for a 6 year old Android version.I also added action bars to the settings and about activities as well as icons to the preference items.
Known issues:
Tested on:
EDIT: Made it really black instead of grey, dear OLED users! Haven't updated the screenshot though.