Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: simplify CLI usage #48

Merged
merged 1 commit into from
Dec 18, 2024
Merged

feat: simplify CLI usage #48

merged 1 commit into from
Dec 18, 2024

Conversation

WofWca
Copy link
Member

@WofWca WofWca commented Nov 24, 2023

This shouldn't break previous valid usages

Sometimes when I want to test some webxdc app real quick I stop and think whether it's worth spending time on trying to recall how to use this tool. This should make things easier for people like me, and new users.

@adbenitez
Copy link
Contributor

this is a bit problematic, if the command is run without subcommands it should print the help, not try to use run, I think current behavior is fine, and personally, I never run webxdc-dev manually in any of my apps, one will use a script in package.json for that, so I think this is not necessary

closing stale PR

@adbenitez adbenitez closed this Nov 16, 2024
@WofWca
Copy link
Member Author

WofWca commented Nov 16, 2024

this is a bit problematic, if the command is run without subcommands it should print the help

A list of commands that don't require arguments:

  • ls
  • nano, vim
  • code
  • vite

For help there is the --help argument, which is pretty much the standard.

I never run webxdc-dev manually in any of my apps, one will use a script in package.json

Then we'd also need to rewrite README, because the global installation method seems to be the recommended one.

Not every app requires a package manager.

closing stale PR

It's not stale anymore, so I'll reopen.

@WofWca WofWca reopened this Nov 16, 2024
@adbenitez
Copy link
Contributor

this needs to be rebased

This shouldn't break previous valid usages
Copy link
Contributor

@adbenitez adbenitez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I recommend leaving location arg mandatory, but I am OK with leaving it as proposed

@adbenitez adbenitez merged commit 0b9fafe into main Dec 18, 2024
1 check passed
@adbenitez adbenitez deleted the simpler-cli branch December 18, 2024 19:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants