-
-
Notifications
You must be signed in to change notification settings - Fork 101
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
BREAKING CHANGE: Deprecate webtorrent-hybrid #195
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This package is deprecated as of WebTorrent >= 2.3.0 as native WebRTC support has been added to WebTorrent. Please switch to using the "webtorrent" package.
New and removed dependencies detected. Learn more about Socket for GitHub ↗︎
🚮 Removed packages: npm/[email protected] |
ThaUnknown
reviewed
Jun 2, 2024
ThaUnknown
reviewed
Jun 2, 2024
Update `Deprecated Warning` to `Deprecation Warning` Co-authored-by: Cas_ <[email protected]>
…ackers to magnetURIs which do not already have them.
ThaUnknown
reviewed
Jun 2, 2024
ThaUnknown
approved these changes
Jun 2, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
webtorrent-bot
pushed a commit
that referenced
this pull request
Jun 2, 2024
# [6.0.0](v5.0.2...v6.0.0) (2024-06-02) * BREAKING CHANGE: Deprecate webtorrent-hybrid (#195) ([fe511bf](fe511bf)), closes [#195](#195) ### BREAKING CHANGES * Deprecate webtorrent-hybrid This package is deprecated as of WebTorrent >= 2.3.0 as native WebRTC support has been added to WebTorrent. Please switch to using the "webtorrent" package. * fix: Update ci to use NodeJS 16 to match package.json * Update README.md Update `Deprecated Warning` to `Deprecation Warning` Co-authored-by: Cas_ <[email protected]> * fix: re-add WEBTORRENT_ANNOUNCE which is used for adding websocket trackers to magnetURIs which do not already have them. * feat: update webtorrent-cli to v5
🎉 This PR is included in version 6.0.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the purpose of this pull request? (put an "X" next to item)
[ ] Documentation update
[ ] Bug fix
[ ] New feature
[x] Other, please explain:
What changes did you make? (Give an overview)
As of WebTorrent >= 2.3.0 WebRTC support has been added to the WebTorrent package via webrtc-polyfill and node-datachannel, removing the need for
webtorrent-hybrid
.Which issue (if any) does this pull request address?
webtorrent-hyrbid
and movingwrtc
intowebtorrent
webtorrent#1734Is there anything you'd like reviewers to focus on?