-
Notifications
You must be signed in to change notification settings - Fork 3.2k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
[Gap Decorations]: Parse
row-rule-outset property
This CL introduces parsing for the `row-rule-outset` property which is used to offset the endpoints of gap decorations relative to the gap intersection points. See: https://drafts.csswg.org/css-gaps-1/#outset Bug: 357648037 Change-Id: I94ce9cce75919c44ddb638166c2e43d6b0f9b8bd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6236266 Reviewed-by: Alison Maher <[email protected]> Reviewed-by: Kevin Babbitt <[email protected]> Commit-Queue: Sam Davis Omekara <[email protected]> Reviewed-by: Kurt Catti-Schmidt <[email protected]> Cr-Commit-Position: refs/heads/main@{#1417171}
- Loading branch information
1 parent
f832c5c
commit ddfb3fc
Showing
3 changed files
with
10 additions
and
10 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -2,7 +2,7 @@ | |
| <html> | ||
| <head> | ||
| <meta charset="utf-8"> | ||
| <title>CSS Gaps: column-rule-outset getComputedStyle()</title> | ||
| <title>CSS Gaps: *-rule-outset getComputedStyle()</title> | ||
| <link rel="author" title="Sam Davis Omekara Jr." href="mailto:[email protected]"> | ||
| <link rel="help" href="https://drafts.csswg.org/css-gaps-1/#outset"> | ||
| <script src="/resources/testharness.js"></script> | ||
|
|
@@ -22,9 +22,9 @@ | |
| test_computed_value("column-rule-outset", "-20px"); | ||
| test_computed_value("column-rule-outset", "0.5em", "20px"); | ||
| test_computed_value("column-rule-outset", "calc(10px + 0.5em)", "30px"); | ||
| test_computed_value("column-rule-outset", "calc(10px - 0.5em)", "-10px"); | ||
| test_computed_value("column-rule-outset", "30%"); | ||
| test_computed_value("column-rule-outset", "calc(25% + 10px)"); | ||
| test_computed_value("row-rule-outset", "calc(10px - 0.5em)", "-10px"); | ||
| test_computed_value("row-rule-outset", "30%"); | ||
| test_computed_value("row-rule-outset", "calc(25% + 10px)"); | ||
| </script> | ||
| </body> | ||
| </html> | ||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -2,7 +2,7 @@ | |
| <html> | ||
| <head> | ||
| <meta charset="utf-8"> | ||
| <title>CSS Gaps: parsing column-rule-outset with invalid values</title> | ||
| <title>CSS Gaps: parsing *-rule-outset with invalid values</title> | ||
| <link rel="author" title="Sam Davis Omekara Jr." href="mailto:[email protected]"> | ||
| <link rel="help" href="https://drafts.csswg.org/css-gaps-1/#outset"> | ||
| <script src="/resources/testharness.js"></script> | ||
|
|
@@ -14,8 +14,8 @@ | |
| <script> | ||
| test_invalid_value('column-rule-outset', 'auto'); | ||
| test_invalid_value('column-rule-outset', 'none'); | ||
| test_invalid_value('column-rule-outset', '10'); | ||
| test_invalid_value('column-rule-outset', '10px 20px'); | ||
| test_invalid_value('row-rule-outset', '10'); | ||
| test_invalid_value('row-rule-outset', '10px 20px'); | ||
| </script> | ||
| </body> | ||
| </html> | ||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -2,7 +2,7 @@ | |
| <html> | ||
| <head> | ||
| <meta charset="utf-8"> | ||
| <title>CSS Gaps: parsing column-rule-outset with valid values</title> | ||
| <title>CSS Gaps: parsing *-rule-outset with valid values</title> | ||
| <link rel="author" title="Sam Davis Omekara Jr." href="mailto:[email protected]"> | ||
| <link rel="help" href="https://drafts.csswg.org/css-gaps-1/#outset"> | ||
| <script src="/resources/testharness.js"></script> | ||
|
|
@@ -15,8 +15,8 @@ | |
| test_valid_value('column-rule-outset', '0', '0px'); | ||
| test_valid_value('column-rule-outset', '-20px'); | ||
| test_valid_value('column-rule-outset', '5%'); | ||
| test_valid_value('column-rule-outset', '10vmin'); | ||
| test_valid_value('column-rule-outset', 'calc(8em + 4ex)'); | ||
| test_valid_value('row-rule-outset', '10vmin'); | ||
| test_valid_value('row-rule-outset', 'calc(8em + 4ex)'); | ||
| </script> | ||
| </body> | ||
| </html> | ||