Skip to content

perf: improve ensure min size fit #11181

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

perf: improve ensure min size fit #11181

wants to merge 1 commit into from

Conversation

LingyuCoder
Copy link
Contributor

Summary

Before:
image

After:
image

Related links

Checklist

  • Tests updated (or not required).
  • Documentation updated (or not required).

@netlify Netlify
Copy link

netlify bot commented Jul 25, 2025 •
edited
Loading

✅ Deploy Preview for rspack canceled.

Name Link
🔨 Latest commit 9655a86
🔍 Latest deploy log https://app.netlify.com/projects/rspack/deploys/68836ae3cb887200086346ec

@github-actions github-actions bot added release: performance release: performance related release(mr only) team The issue/pr is created by the member of Rspack. labels Jul 25, 2025
@github-actions GitHub Actions
Copy link
Contributor

📦 Binary Size-limit

Comparing 9655a86 to chore: use rslint to do typed linting (#11146) by hardfist

❌ Size increased by 6.00KB from 49.00MB to 49.01MB (⬆️0.01%)

@codspeed-hq CodSpeed HQ
Copy link

codspeed-hq bot commented Jul 25, 2025

CodSpeed Performance Report

Merging #11181 will not alter performance

Comparing perf/ensure-min-size-fit (9655a86) with main (bc0fb4b)

Summary

✅ 16 untouched benchmarks

@LingyuCoder LingyuCoder marked this pull request as ready for review July 25, 2025 11:51
@Copilot Copilot AI review requested due to automatic review settings July 25, 2025 11:51
@LingyuCoder LingyuCoder requested a review from JSerFeng as a code owner July 25, 2025 11:51
Copilot
Copilot AI reviewed Jul 25, 2025
View reviewed changes
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR improves performance of the split chunks plugin by parallelizing the module group processing in the ensure_min_size function. The change replaces sequential iteration with parallel iteration using Rayon.

  • Adds parallel processing to the ensure_min_size_fit operation using Rayon
  • Changes from sequential .iter_mut() to parallel .par_iter_mut() for module group iteration

@LingyuCoder LingyuCoder enabled auto-merge (squash) July 25, 2025 15:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

Copilot code review Copilot Copilot left review comments

@JSerFeng JSerFeng Awaiting requested review from JSerFeng JSerFeng is a code owner

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
release: performance release: performance related release(mr only) team The issue/pr is created by the member of Rspack.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@LingyuCoder