fix: add yarn pnp support to read_dir #11124
Open
+27
−0
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Makes
read_dir
work when using yarn pnp, preventing a crash when a third party module contains a dynamic require and making it properly the zip crawl directories.I do not think that the require context ever worked with yarn pnp before anyway, but at least it did not crash prior to #10960.
This is not efficient at all because it iterates over the whole index of the zip file every time, the proper fix would be to add a mapping between folders and children directly in the pnp-rs crate (cc @arcanis 👋) but at least it should stop rspack from crashing in the meantime:
Related links
Should solve #11123
Checklist