- Sponsor
-
Notifications
You must be signed in to change notification settings - Fork 1.4k
[V3] Badging #4234
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
+7,368
−8
Merged
[V3] Badging #4234
Changes from 1 commit
Commits
Show all changes
25 commits
Select commit
Hold shift + click to select a range
94d03d5
badge service
popaprozac be28da2
windows badge
popaprozac b55f4ea
add example, update docs, update changelog
popaprozac f311a33
update changelog
popaprozac d1d57c1
rabbit suggestions
popaprozac 7287c1e
render label on windows and sensible defaults
popaprozac c0a83ef
Update docs/src/content/docs/learn/badges.mdx
popaprozac 59cc71b
fix code block
popaprozac 9fa5967
Include assets in example
leaanthony 5154f0b
Add FontManager to better handle fonts. Remove the go-findfont depend…
leaanthony f7aaf84
Update v3/pkg/services/badge/badge_windows.go
leaanthony 52df483
Tidy up
leaanthony e991615
Add badge options. Add new example.
leaanthony 8d9dc19
Update badge-custom example
leaanthony 73705dc
add build tag
popaprozac dabc18f
center circle color
popaprozac 800810f
extract taskbar
popaprozac 9e3786c
add comments and macOS stub
popaprozac ce8c102
fix double uninit
popaprozac 40117e6
fallback to default badge if font cannot be used
popaprozac af3c6af
update docs and readmes
popaprozac 51c0d1d
update headers
popaprozac 900da01
add set custom badge and update docs/examples/readmes
popaprozac b942293
Update docs/src/content/docs/learn/badges.mdx
popaprozac 934d8c8
update docs
popaprozac File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Loading status checks…
render label on windows and sensible defaults
- Loading branch information
commit 7287c1eb5cdccdc148a0bf9ccfc9f1cf9c287724
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🛠️ Refactor suggestion
Potential memory leak: badge image creation
The
createBadge()
method is called every timeSetBadge()
is called, resulting in a new image allocation. This could lead to memory pressure under frequent badge updates.Consider caching the badge image and only recreating it when necessary: