v3-alpha-bugfix/4061-input-issue-mac #4222
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
WalkthroughThis pull request updates the changelog to document a fix for an input issue on macOS and modifies the CSS files across multiple frontend templates. The CSS changes primarily involve removing the closing brace of the Changes
Assessment against linked issues
Possibly related PRs
Poem
📜 Recent review detailsConfiguration used: .coderabbit.yaml 📒 Files selected for processing (1)
✅ Files skipped from review due to trivial changes (1)
⏰ Context from checks skipped due to timeout of 90000ms (4)
🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
Documentation and Community
|
Deploying wails with
|
| Latest commit: |
facc47b
|
| Status: | 🚫 Build failed. |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
🧹 Nitpick comments (1)
docs/src/content/docs/changelog.mdx (1)
118-118: Add PR reference and OS icon for consistencyFor consistency with other macOS-specific fixes in the changelog, consider prefixing the entry with and adding the PR number (e.g., [#4222]) or commit link:
- - Fixed input issue with macOS by [@leaanthony](https://github.com/leaanthony). + - Fixed input issue with macOS by [@leaanthony](https://github.com/leaanthony) in [#4222].
📜 Review details
Configuration used: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (20)
docs/src/content/docs/changelog.mdx(1 hunks)v3/internal/templates/lit-ts/frontend/public/style.css(0 hunks)v3/internal/templates/lit/frontend/public/style.css(0 hunks)v3/internal/templates/preact-ts/frontend/public/style.css(0 hunks)v3/internal/templates/preact/frontend/public/style.css(0 hunks)v3/internal/templates/qwik-ts/frontend/public/style.css(0 hunks)v3/internal/templates/qwik/frontend/public/style.css(0 hunks)v3/internal/templates/react-swc-ts/frontend/public/style.css(0 hunks)v3/internal/templates/react-swc/frontend/public/style.css(0 hunks)v3/internal/templates/react-ts/frontend/public/style.css(0 hunks)v3/internal/templates/react/frontend/public/style.css(0 hunks)v3/internal/templates/solid-ts/frontend/public/style.css(0 hunks)v3/internal/templates/solid/frontend/public/style.css(0 hunks)v3/internal/templates/svelte-ts/frontend/public/style.css(0 hunks)v3/internal/templates/svelte/frontend/public/style.css(0 hunks)v3/internal/templates/sveltekit-ts/frontend/static/style.css(0 hunks)v3/internal/templates/sveltekit/frontend/frontend/style.css(0 hunks)v3/internal/templates/sveltekit/frontend/static/style.css(0 hunks)v3/internal/templates/vanilla-ts/frontend/public/style.css(1 hunks)v3/internal/templates/vanilla/frontend/public/style.css(0 hunks)
💤 Files with no reviewable changes (18)
- v3/internal/templates/preact-ts/frontend/public/style.css
- v3/internal/templates/react/frontend/public/style.css
- v3/internal/templates/qwik-ts/frontend/public/style.css
- v3/internal/templates/sveltekit/frontend/frontend/style.css
- v3/internal/templates/sveltekit/frontend/static/style.css
- v3/internal/templates/vanilla/frontend/public/style.css
- v3/internal/templates/solid-ts/frontend/public/style.css
- v3/internal/templates/lit/frontend/public/style.css
- v3/internal/templates/qwik/frontend/public/style.css
- v3/internal/templates/preact/frontend/public/style.css
- v3/internal/templates/sveltekit-ts/frontend/static/style.css
- v3/internal/templates/solid/frontend/public/style.css
- v3/internal/templates/react-ts/frontend/public/style.css
- v3/internal/templates/react-swc-ts/frontend/public/style.css
- v3/internal/templates/svelte/frontend/public/style.css
- v3/internal/templates/svelte-ts/frontend/public/style.css
- v3/internal/templates/react-swc/frontend/public/style.css
- v3/internal/templates/lit-ts/frontend/public/style.css
🧰 Additional context used
🪛 Biome (1.9.4)
v3/internal/templates/vanilla-ts/frontend/public/style.css
[error] 22-23: An empty block isn't allowed.
Consider removing the empty block or adding styles inside it.
(lint/suspicious/noEmptyBlock)
⏰ Context from checks skipped due to timeout of 90000ms (4)
- GitHub Check: semgrep-cloud-platform/scan
- GitHub Check: Analyze (javascript-typescript)
- GitHub Check: Analyze (go)
- GitHub Check: Cloudflare Pages
fbbdev
approved these changes
Apr 18, 2025
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes issue where on some later versions of macOS, inputs would not work correctly.
Fixes #4061
Type of change
Please select the option that is relevant.
Summary by CodeRabbit
Documentation
Style