Skip to content

[v3] fix: general auto save and general password auto save always enabled #4134

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Apr 18, 2025
Merged

[v3] fix: general auto save and general password auto save always enabled #4134

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
0be2efc
fix: general auto save and general password auto save always enabled
oSethoum Mar 12, 2025
46dd5ef
add: entry in changelog.mdx
oSethoum Mar 12, 2025
81211d5
Merge branch 'v3-alpha' into v3-alpha-bugfix-auto_fill-auto_password_…
leaanthony Apr 18, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions docs/src/content/docs/changelog.mdx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -75,6 +75,7 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
- Add method `Close` on `sqlite` service to close the DB manually by [@fbbdev](https://github.com/fbbdev) in [#4067](https://github.com/wailsapp/wails/pull/4067)
- Add cancellation support for query methods on `sqlite` service by [@fbbdev](https://github.com/fbbdev) in [#4067](https://github.com/wailsapp/wails/pull/4067)
- Add prepared statement support to `sqlite` service with JS bindings by [@fbbdev](https://github.com/fbbdev) in [#4067](https://github.com/wailsapp/wails/pull/4067)
- Fix auto save and password auto save always enabled by [@oSethoum](https://github.com/osethoum) in [#4134](https://github.com/wailsapp/wails/pull/4134)
- Add `SetMenu()` on window to allow for setting a menu on a window by [@leaanthony](https://github.com/leaanthony)
- Add Notification support by [@popaprozac] in [#4098](https://github.com/wailsapp/wails/pull/4098)
-  Add File Association support for mac by [@wimaha](https://github.com/wimaha) in [#4177](https://github.com/wailsapp/wails/pull/4177)
Expand Down
29 changes: 12 additions & 17 deletions v3/pkg/application/webview_window_windows.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1672,26 +1672,21 @@ func (w *windowsWebviewWindow) setupChromium() {

}

if opts.GeneralAutofillEnabled {
err = chromium.PutIsGeneralAutofillEnabled(true)
if err != nil {
if errors.Is(edge.UnsupportedCapabilityError, err) {
// warning
globalApplication.warning("unsupported capability: GeneralAutofillEnabled")
} else {
globalApplication.handleFatalError(err)
}
err = chromium.PutIsGeneralAutofillEnabled(opts.GeneralAutofillEnabled)
if err != nil {
if errors.Is(err, edge.UnsupportedCapabilityError) {
globalApplication.warning("unsupported capability: GeneralAutofillEnabled")
} else {
globalApplication.handleFatalError(err)
}
}

if opts.PasswordAutosaveEnabled {
err = chromium.PutIsPasswordAutosaveEnabled(true)
if err != nil {
if errors.Is(edge.UnsupportedCapabilityError, err) {
globalApplication.warning("unsupported capability: PasswordAutosaveEnabled")
} else {
globalApplication.handleFatalError(err)
}
err = chromium.PutIsPasswordAutosaveEnabled(opts.PasswordAutosaveEnabled)
if err != nil {
if errors.Is(err, edge.UnsupportedCapabilityError) {
globalApplication.warning("unsupported capability: PasswordAutosaveEnabled")
} else {
globalApplication.handleFatalError(err)
}
}

Expand Down
Loading