Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

11th tutorial video review #122

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

11th tutorial video review #122

wants to merge 3 commits into from

Conversation

handealptekin
Copy link
Contributor

@netlify Netlify
Copy link

netlify bot commented Nov 16, 2023 •
edited
Loading

✅ Deploy Preview for whatiswot ready!

Name Link
🔨 Latest commit c32df15
🔍 Latest deploy log https://app.netlify.com/sites/whatiswot/deploys/6576fc8fe821a800082b4255
😎 Deploy Preview https://deploy-preview-122--whatiswot.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

egekorkan
egekorkan requested changes Nov 17, 2023
View reviewed changes
Tutorials/whatiswot/11-Architecture_Patterns/11-Architecture-Patterns.vtt Outdated Show resolved Hide resolved
Tutorials/whatiswot/11-Architecture_Patterns/11-Architecture-Patterns.vtt Outdated Show resolved Hide resolved
Tutorials/whatiswot/11-Architecture_Patterns/11-Architecture-Patterns.vtt Outdated Show resolved Hide resolved
Tutorials/whatiswot/11-Architecture_Patterns/11-Architecture-Patterns.vtt Outdated Show resolved Hide resolved
Tutorials/whatiswot/11-Architecture_Patterns/11-Architecture-Patterns.vtt Outdated Show resolved Hide resolved
Tutorials/whatiswot/11-Architecture_Patterns/11-Architecture-Patterns.vtt Outdated Show resolved Hide resolved
Tutorials/whatiswot/11-Architecture_Patterns/11-Architecture-Patterns.vtt Outdated Show resolved Hide resolved
Tutorials/whatiswot/11-Architecture_Patterns/11-Architecture-Patterns.vtt Outdated Show resolved Hide resolved
@egekorkan egekorkan added the tutorial topics on our tutorials such as what is wot or quickstart label Dec 1, 2023
egekorkan
egekorkan requested changes Dec 8, 2023
View reviewed changes
Copy link
Collaborator

@egekorkan egekorkan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor improvements are still needed, previous concerns are all addressed.

Tutorials/whatiswot/11-Architecture_Patterns/11-Architecture-Patterns.vtt Show resolved Hide resolved
Tutorials/whatiswot/11-Architecture_Patterns/11-Architecture-Patterns.vtt Outdated Show resolved Hide resolved
Tutorials/whatiswot/11-Architecture_Patterns/11-Architecture-Patterns.vtt Outdated Show resolved Hide resolved
@handealptekin
Copy link
Contributor Author

  • Pronunciation of "server" is altered. Now it sound better but there is still some ambiguity where it says "server role". However I tried many pronunciations and think that this one is the best.
  • Commas are added where needed.

@egekorkan
Copy link
Collaborator

Pronunciation is indeed not perfect but it is at least not wrong :)

All my points are addressed, will wait for @relu91 feedback

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@egekorkan egekorkan egekorkan approved these changes

Assignees
No one assigned
Labels
tutorial topics on our tutorials such as what is wot or quickstart
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@handealptekin @egekorkan