Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This Pull Request (PR) fixes the following issues
Is a precursor to #431 (makes progress but does not solve the whole issue)
Pull Request (PR) description
4 parts to this PR:
openldap_overlay
in a new 'describe' layer (so we can isolate the existing 'create an overlay' test from new test)..instances
work correctly"' test toopenldap_overlay
. The current tests are "can we make a new overlay" but this adds a class of tests for "given slapcat of an existing deployment, do we detect+parse the overlay correctly?" - richer testing on existing behavior, and a framework for the next commit.olcChainConfig
and the ability to attach the overlay to thefrontend
pseudo-database, following a prior-art pattern from theopenldap_access
provider. ... and tests for adding/detecting the overlay.#431 wants to add a Chain config, which is a two-part request: adding the Chain overlay, and then adding the database you're chaining TO. However, that second part is more complex changes to
openldap_database
, and it's all dependent upon having this overlay in place first. So while this isn't the complete solution I think there's enough in here to fold in (because if this gets rejected, the database work is of no value)