Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RSDK-9621: Add Discover Service and GetModelsFromModules to Typescript #436

Open
wants to merge 15 commits into
base: main
Choose a base branch
from

Conversation

martha-johnston
Copy link
Contributor

@martha-johnston martha-johnston commented Jan 2, 2025

add discoverResources and getModelsFromModules

edit: also add deprecation warning to discoverComponents RSDK-9635

@martha-johnston martha-johnston requested a review from a team as a code owner January 2, 2025 20:51
@martha-johnston martha-johnston marked this pull request as draft January 2, 2025 20:51
@martha-johnston
Copy link
Contributor Author

pretty sure I cannot fully test this until api is merged in this pr

@randhid
Copy link
Member

randhid commented Jan 8, 2025

Let's hold off on the SDK addition work for now given the reflection issue John found with the tagger proto. You can keep these in draft.

@martha-johnston martha-johnston marked this pull request as ready for review January 22, 2025 16:28
@martha-johnston
Copy link
Contributor Author

accidentally moved this from a draft too soon, actually ready for review now @njooma @stuqdog

@@ -103,6 +104,8 @@ export interface Robot {
): Promise<Uint8Array>;

/**
* Deprecated: v0.38.0, use the Discovery Service APIs instead.
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
* Deprecated: v0.38.0, use the Discovery Service APIs instead.
* Deprecated: v0.36.0, use the Discovery Service APIs instead.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

next release


async discoverComponents(queries: DiscoveryQuery[]) {
console.warn(
'RobotClient.discover_components is deprecated. It will be removed on March 10 2025. Use the DiscoveryService APIs instead.'
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
'RobotClient.discover_components is deprecated. It will be removed on March 10 2025. Use the DiscoveryService APIs instead.'
'RobotClient.discoverComponents is deprecated. It will be removed on March 10 2025. Use the DiscoveryService APIs instead.'

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants