-
Notifications
You must be signed in to change notification settings - Fork 40
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
RSDK-9621: Add Discover Service and GetModelsFromModules to Typescript #436
base: main
Are you sure you want to change the base?
Conversation
pretty sure I cannot fully test this until api is merged in this pr |
Let's hold off on the SDK addition work for now given the reflection issue John found with the tagger proto. You can keep these in draft. |
@@ -103,6 +104,8 @@ export interface Robot { | |||
): Promise<Uint8Array>; | |||
|
|||
/** | |||
* Deprecated: v0.38.0, use the Discovery Service APIs instead. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
* Deprecated: v0.38.0, use the Discovery Service APIs instead. | |
* Deprecated: v0.36.0, use the Discovery Service APIs instead. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
next release
|
||
async discoverComponents(queries: DiscoveryQuery[]) { | ||
console.warn( | ||
'RobotClient.discover_components is deprecated. It will be removed on March 10 2025. Use the DiscoveryService APIs instead.' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
'RobotClient.discover_components is deprecated. It will be removed on March 10 2025. Use the DiscoveryService APIs instead.' | |
'RobotClient.discoverComponents is deprecated. It will be removed on March 10 2025. Use the DiscoveryService APIs instead.' |
add
discoverResources
andgetModelsFromModules
edit: also add deprecation warning to
discoverComponents
RSDK-9635