Add new exception type for mdns

viamrobotics · Nov 14, 2023 · 3ac6b83 · 3ac6b83
1 parent 60782fa
commit 3ac6b83
Show file tree

Hide file tree

Showing 4 changed files with 25 additions and 13 deletions.
diff --git a/lib/src/errors.dart b/lib/src/errors.dart
diff --git a/lib/src/exceptions.dart b/lib/src/exceptions.dart
@@ -0,0 +1,19 @@
+/// Error thrown with connection is lost
+class ConnectionLostException implements Exception {
+  final String? message;
+
+  const ConnectionLostException([this.message]);
+
+  @override
+  String toString() => message ?? 'ConnectionLostError';
+}
+
+/// Error thrown when mDNS fails to find a match on the local network
+class NotLocalAddressException implements Exception {
+  final String address;
+
+  const NotLocalAddressException(this.address);
+
+  @override
+  String toString() => 'Address not on local network';
+}
diff --git a/lib/src/rpc/dial.dart b/lib/src/rpc/dial.dart
@@ -8,6 +8,7 @@ import 'package:grpc/grpc_connection_interface.dart';
 import 'package:grpc/grpc_or_grpcweb.dart';
 import 'package:logger/logger.dart';
 
+import '../exceptions.dart';
 import '../gen/proto/rpc/v1/auth.pb.dart' as pb;
 import '../gen/proto/rpc/v1/auth.pbgrpc.dart';
 import '../gen/proto/rpc/webrtc/v1/signaling.pbgrpc.dart';
@@ -123,6 +124,8 @@ Future<ClientChannelBase> dial(String address, DialOptions? options, String Func
         .._usingMdns = true
         ..authEntity = address;
       return _dialWebRtc(mdnsUri, dialOptsCopy, sessionCallback);
+    } on NotLocalAddressException catch (e) {
+      _logger.d(e.toString());
     } catch (e) {
       _logger.d('Error dialing with mDNS; falling back to other methods', error: e);
     }
@@ -158,8 +161,7 @@ Future<String> searchMdns(String address) async {
   }
 
   await discovery.stop();
-
-  throw Exception('Address not on local network');
+  throw NotLocalAddressException(address);
 }
 
 Future<ClientChannelBase> _dialDirectGrpc(String address, DialOptions options, String Function() sessionCallback) async {

diff --git a/lib/src/rpc/web_rtc/web_rtc_transport_stream.dart b/lib/src/rpc/web_rtc/web_rtc_transport_stream.dart
@@ -5,7 +5,7 @@ import 'package:flutter_webrtc/flutter_webrtc.dart';
 import 'package:grpc/grpc.dart';
 import 'package:grpc/grpc_connection_interface.dart';
 
-import '../../errors.dart';
+import '../../exceptions.dart';
 import '../../gen/proto/rpc/webrtc/v1/grpc.pb.dart' as grpc;
 import 'web_rtc_client.dart';
 
@@ -63,7 +63,7 @@ class WebRtcTransportStream extends GrpcTransportStream {
       if (connectionState == RTCPeerConnectionState.RTCPeerConnectionStateFailed ||
           connectionState == RTCPeerConnectionState.RTCPeerConnectionStateDisconnected) {
         onRequestFailure(
-          const ConnectionLostError('RTCPeerConnection lost'),
+          const ConnectionLostException('RTCPeerConnection lost'),
           StackTrace.current,
         );
         return;