-
Notifications
You must be signed in to change notification settings - Fork 7.8k
fix: 修复 API 组件中的 fetchApi 函数的参数使用问题 #6393
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
WalkthroughThe Changes
Suggested reviewers
Poem
📜 Recent review detailsConfiguration used: CodeRabbit UI 📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
⏰ Context from checks skipped due to timeout of 90000ms (2)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 1
🧹 Nitpick comments (2)
packages/effects/common-ui/src/components/api-component/api-component.vue (2)
157-162
: Cloneparams
before mutating to keep props & refs immutable
unref(params)
returns a shallow-copied object, but its nested properties are still shared withprops.params
/innerParams
.
IfbeforeFetch
mutatesfinalParams
in place, those nested objects mutate the originals, breaking the immutability guarantee this PR tries to restore.- let finalParams = unref(params); + // deep-clone to detach from `props` & reactive refs + let finalParams = structuredClone(unref(params)); // or use lodash.cloneDeepThis keeps side-effects local and predictable.
157-162
: Minor naming nit:params
vsprops.params
is confusingThe local computed
params
shadowsprops.params
, and both are referenced insidefetchApi
.
Renaming the computed to something distinct (e.g.mergedParams
) improves readability and avoids accidental misuse.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
packages/effects/common-ui/src/components/api-component/api-component.vue
(1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms (2)
- GitHub Check: post-update (windows-latest)
- GitHub Check: post-update (ubuntu-latest)
Uh oh!
There was an error while loading. Please reload this page.