Skip to content

fix: 修复 API 组件中的 fetchApi 函数的参数使用问题 #6393

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 20, 2025

Conversation

lghuahua
Copy link
Contributor

@lghuahua lghuahua commented Jun 18, 2025

  • 目前在fetchApi中参数使用的是props的params, 但是当innerParams变化时,api调用使用的props的params并不包含innerParams。所以应该改成使用计算属性的params
  • beforeFetch回调使用params的副本
  • 修复在上一个请求尚未完成前如果params发生了变更,将不会再触发新的api请求。这是一种较极端的情况

Copy link

changeset-bot bot commented Jun 18, 2025

⚠️ No Changeset found

Latest commit: f744acb

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link
Contributor

coderabbitai bot commented Jun 18, 2025

Walkthrough

The fetchApi function was enhanced to manage concurrent API calls by introducing a hasPendingRequest flag that queues requests sequentially. Parameters for the API call now come from a computed mergedParams property combining props and internal state, with beforeFetch applied to a deep clone to prevent mutations. The watch target was updated accordingly.

Changes

File(s) Change Summary
.../api-component/api-component.vue Added hasPendingRequest flag for request queuing; replaced direct use of props.params with computed mergedParams; applied beforeFetch on deep clone of merged parameters; updated watch target; imported cloneDeep and nextTick.

Suggested reviewers

  • anncwb
  • jinmao88
  • vince292007

Poem

🐇 Hopping through code with a careful pace,
Queuing requests in a gentle race.
Params merged tight, no mutation in sight,
BeforeFetch cleans with a soft, bright light.
API calls now dance in line—
A rabbit’s code, precise and fine! ✨🐰


📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between eca9c8b and f744acb.

📒 Files selected for processing (1)
  • packages/effects/common-ui/src/components/api-component/api-component.vue (5 hunks)
🚧 Files skipped from review as they are similar to previous changes (1)
  • packages/effects/common-ui/src/components/api-component/api-component.vue
⏰ Context from checks skipped due to timeout of 90000ms (2)
  • GitHub Check: post-update (windows-latest)
  • GitHub Check: post-update (ubuntu-latest)

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Explain this complex logic.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai explain this code block.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and explain its main purpose.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🧹 Nitpick comments (2)
packages/effects/common-ui/src/components/api-component/api-component.vue (2)

157-162: Clone params before mutating to keep props & refs immutable

unref(params) returns a shallow-copied object, but its nested properties are still shared with props.params / innerParams.
If beforeFetch mutates finalParams in place, those nested objects mutate the originals, breaking the immutability guarantee this PR tries to restore.

-    let finalParams = unref(params);
+    // deep-clone to detach from `props` & reactive refs
+    let finalParams = structuredClone(unref(params)); // or use lodash.cloneDeep

This keeps side-effects local and predictable.


157-162: Minor naming nit: params vs props.params is confusing

The local computed params shadows props.params, and both are referenced inside fetchApi.
Renaming the computed to something distinct (e.g. mergedParams) improves readability and avoids accidental misuse.

📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 97b8e28 and eca9c8b.

📒 Files selected for processing (1)
  • packages/effects/common-ui/src/components/api-component/api-component.vue (1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms (2)
  • GitHub Check: post-update (windows-latest)
  • GitHub Check: post-update (ubuntu-latest)

@mynetfan mynetfan merged commit 986eaca into vbenjs:main Jun 20, 2025
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants