fix: requestClient.upload会将vbenform中value为undefined的值转为字符串undefined’提… #6300

zwtvip · 2025-05-28T15:46:03Z

表单格式提交，vbenform中未赋值的话，默认是undefined，这会导致 form.append会将undefined 转为字符串‘undefined’ 提交给后台保存到数据库

Summary by CodeRabbit

Bug Fixes
- Improved file upload handling to prevent undefined values from being included in form data.

…交给后台保存

changeset-bot · 2025-05-28T15:46:06Z

⚠️ No Changeset found

Latest commit: 13f778b

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

coderabbitai · 2025-05-28T15:46:10Z

Walkthrough

The update refines the file upload logic by ensuring that only defined values are appended to the FormData object. This is achieved by importing and utilizing an isUndefined utility function, preventing undefined values from being included in form submissions. No changes were made to public interfaces or exports.

Changes

File(s)	Change Summary
.../request/src/request-client/modules/uploader.ts	Added `isUndefined` import and check before appending to FormData.

Suggested reviewers

mynetfan
anncwb
jinmao88

Poem

A rabbit hops through code so neat,
Checks for undefined—what a treat!
No more stray values in the form,
Uploads now follow a tidier norm.
With every hop, the bugs retreat—
This patch makes uploads quite complete!
🐇✨

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 9803e85 and 13f778b.

📒 Files selected for processing (1)

packages/effects/request/src/request-client/modules/uploader.ts (2 hunks)

🚧 Files skipped from review as they are similar to previous changes (1)

packages/effects/request/src/request-client/modules/uploader.ts

⏰ Context from checks skipped due to timeout of 90000ms (5)

GitHub Check: Test (windows-latest)
GitHub Check: Check (windows-latest)
GitHub Check: Lint (windows-latest)
GitHub Check: post-update (ubuntu-latest)
GitHub Check: post-update (windows-latest)

✨ Finishing Touches

📝 Generate Docstrings

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

Review comments: Directly reply to a review comment made by CodeRabbit. Example:
- I pushed a fix in commit <commit_id>, please review it.
- Explain this complex logic.
- Open a follow-up GitHub issue for this discussion.
Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
- @coderabbitai explain this code block.
- @coderabbitai modularize this function.
PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
- @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
- @coderabbitai read src/utils.ts and explain its main purpose.
- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
- @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

@coderabbitai pause to pause the reviews on a PR.
@coderabbitai resume to resume the paused reviews.
@coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
@coderabbitai full review to do a full review from scratch and review all the files again.
@coderabbitai summary to regenerate the summary of the PR.
@coderabbitai generate docstrings to generate docstrings for this PR.
@coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
@coderabbitai resolve resolve all the CodeRabbit review comments.
@coderabbitai configuration to show the current CodeRabbit configuration for the repository.
@coderabbitai help to get help.

Other keywords and placeholders

Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (`.coderabbit.yaml`)

You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
Please see the configuration documentation for more information.
If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

Visit our Documentation for detailed information on how to use CodeRabbit.
Join our Discord Community to get help, request features, and share feedback.
Follow us on X/Twitter for updates and announcements.

coderabbitai

Actionable comments posted: 0

🧹 Nitpick comments (1)

packages/effects/request/src/request-client/modules/uploader.ts (1)
26-26: Excellent fix for the undefined string conversion issue.

This change correctly prevents undefined values from being converted to the string "undefined" when appended to FormData, which directly addresses the issue described in the PR objectives.

Consider array elements for consistency:

While this fix addresses the main issue, note that array elements could also be undefined and would still be appended as "undefined" strings (lines 22-24). Consider whether similar checking should be applied there for consistency:
value.forEach((item, index) => {
-  formData.append(`${key}[${index}]`, item);
+  !isUndefined(item) && formData.append(`${key}[${index}]`, item);
});

📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 96a10ca and 9803e85.

📒 Files selected for processing (1)

packages/effects/request/src/request-client/modules/uploader.ts (2 hunks)

🧰 Additional context used

🧬 Code Graph Analysis (1)

packages/effects/request/src/request-client/modules/uploader.ts (1)

packages/@core/base/shared/src/utils/inference.ts (1)

isUndefined (162-162)

⏰ Context from checks skipped due to timeout of 90000ms (8)

GitHub Check: Check (ubuntu-latest)
GitHub Check: Lint (ubuntu-latest)
GitHub Check: Lint (windows-latest)
GitHub Check: Check (windows-latest)
GitHub Check: Test (windows-latest)
GitHub Check: Analyze (javascript-typescript)
GitHub Check: post-update (windows-latest)
GitHub Check: post-update (ubuntu-latest)

🔇 Additional comments (1)

packages/effects/request/src/request-client/modules/uploader.ts (1)

4-4: LGTM: Clean import of utility function.

The import correctly brings in the isUndefined utility function that will be used to filter out undefined values before appending to FormData.

jinmao88 · 2025-06-02T00:09:30Z

完善一下

zwtvip · 2025-06-02T00:25:21Z

完善一下

哪里还需要改？

jinmao88 · 2025-06-02T22:08:02Z

@zwtvip ai提示的数组内可能存在undefine

…提交给后台保存

zwtvip · 2025-06-03T14:33:52Z

@zwtvip ai提示的数组内可能存在undefine

已处理

fix: requestClient.upload会将vbenform中value为undefined的值转为字符串undefined’提…

9803e85

…交给后台保存

zwtvip requested review from anncwb, vince292007, mynetfan and jinmao88 as code owners May 28, 2025 15:46

coderabbitai bot reviewed May 28, 2025

View reviewed changes

fix: requestClient.upload会将vbenform中value为undefined的值转为字符串'undefined’…

13f778b

…提交给后台保存

jinmao88 merged commit dcccc21 into vbenjs:main Jun 8, 2025
14 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

fix: requestClient.upload会将vbenform中value为undefined的值转为字符串undefined’提… #6300

fix: requestClient.upload会将vbenform中value为undefined的值转为字符串undefined’提… #6300

Uh oh!

zwtvip commented May 28, 2025 •

edited by coderabbitai bot

Loading

Uh oh!

changeset-bot bot commented May 28, 2025 •

edited

Loading

Uh oh!

coderabbitai bot commented May 28, 2025 •

edited

Loading

Chat

Support

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

CodeRabbit Configuration File (`.coderabbit.yaml`)

Documentation and Community

Uh oh!

coderabbitai bot left a comment

Uh oh!

jinmao88 commented Jun 2, 2025

Uh oh!

zwtvip commented Jun 2, 2025

Uh oh!

jinmao88 commented Jun 2, 2025

Uh oh!

zwtvip commented Jun 3, 2025

Uh oh!

Uh oh!

Uh oh!

fix: requestClient.upload会将vbenform中value为undefined的值转为字符串undefined’提… #6300

fix: requestClient.upload会将vbenform中value为undefined的值转为字符串undefined’提… #6300

Uh oh!

Conversation

zwtvip commented May 28, 2025 • edited by coderabbitai bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary by CodeRabbit

Uh oh!

changeset-bot bot commented May 28, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

⚠️ No Changeset found

Uh oh!

coderabbitai bot commented May 28, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Walkthrough

Changes

Suggested reviewers

Poem

Chat

Support

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

CodeRabbit Configuration File (.coderabbit.yaml)

Documentation and Community

Uh oh!

coderabbitai bot left a comment

Choose a reason for hiding this comment

Uh oh!

jinmao88 commented Jun 2, 2025

Uh oh!

zwtvip commented Jun 2, 2025

Uh oh!

jinmao88 commented Jun 2, 2025

Uh oh!

zwtvip commented Jun 3, 2025

Uh oh!

Uh oh!

Uh oh!

zwtvip commented May 28, 2025 •

edited by coderabbitai bot

Loading

changeset-bot bot commented May 28, 2025 •

edited

Loading

coderabbitai bot commented May 28, 2025 •

edited

Loading

CodeRabbit Configuration File (`.coderabbit.yaml`)