docs(settings): 完善 生产环境动态配置 步骤 #6297
Conversation
wyc001122
requested review from
anncwb,
vince292007,
mynetfan,
jinmao88 and
a team
as code owners
|
WalkthroughThe documentation was updated to fix formatting and provide a new example illustrating how to extend the Changes
Suggested reviewers
Poem
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Nitpick comments (3)
docs/src/guide/essentials/settings.md (2)
24-24: Remove duplicate “的” in the tip.
The phrase “以VITE_GLOB_*开头的的变量” contains a duplicated “的”. It should read “以VITE_GLOB_*开头的变量” for clarity.
142-159: Enhance example by handling missing config values.
The code snippet correctly demonstrates extractingVITE_GLOB_OTHER_API_URL. Consider adding a fallback or type guard to avoid runtime undefined errors when the environment variable is absent, for example:const { VITE_GLOB_API_URL, VITE_GLOB_OTHER_API_URL = '' } = config;docs/src/en/guide/essentials/settings.md (1)
143-160: Optional: remind to clear cache after updates.
The code example is spot-on. You might add a note reminding readers to clear their browser cache or CDN cache after modifying_app.config.jsto ensure the new values take effect.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (2)
docs/src/en/guide/essentials/settings.md(2 hunks)docs/src/guide/essentials/settings.md(2 hunks)
⏰ Context from checks skipped due to timeout of 90000ms (6)
- GitHub Check: Test (windows-latest)
- GitHub Check: Check (windows-latest)
- GitHub Check: Check (ubuntu-latest)
- GitHub Check: Analyze (javascript-typescript)
- GitHub Check: post-update (ubuntu-latest)
- GitHub Check: post-update (windows-latest)
🔇 Additional comments (3)
docs/src/guide/essentials/settings.md (1)
140-141: Approve addition of the new bullet foruse-app-config.ts.
The instruction clearly shows where to update the hook to include additional variables.docs/src/en/guide/essentials/settings.md (2)
24-24: Approve clarified packaging tip.
The updated sentence accurately explains thatVITE_GLOB_*variables are added to_app.config.jsduring packaging.
141-141: Approve bullet for modifyinguse-app-config.ts.
The new instruction succinctly guides users on where to add their custom dynamic config.
…into web * 'main' of https://github.com/baohaojie123/vue-vben-admin: types: 扩展user-dropdown组件的menus类型，支持iconify (vbenjs#6283) fix: resolve onClosed method failure in connectedComponent of useVbenModal (vbenjs#6309) fix: 修复使用useVbenVxeGrid配置hasEmptyText、hasEmptyRender不生效的问题 (vbenjs#6310) fix: When defaultHomePage is inconsistent with user.homePath, the pa… (vbenjs#6299) docs(settings): 完善'生产环境动态配置'步骤 (vbenjs#6297) fix: alert width fixed in small screen (vbenjs#6312) style: fix lint error (vbenjs#6298) feat: support for hybrid permission access control mode (vbenjs#6294) fix: fix table-title slot not work (vbenjs#6295) # Conflicts: # docs/src/en/guide/in-depth/access.md
* 'main' of https://github.com/baohaojie123/vue-vben-admin: (35 commits) chore: release 5.5.7 feat: improve vbenCheckButtonGroup (vbenjs#6329) types: 扩展user-dropdown组件的menus类型，支持iconify (vbenjs#6283) fix: resolve onClosed method failure in connectedComponent of useVbenModal (vbenjs#6309) fix: 修复使用useVbenVxeGrid配置hasEmptyText、hasEmptyRender不生效的问题 (vbenjs#6310) fix: When defaultHomePage is inconsistent with user.homePath, the pa… (vbenjs#6299) docs(settings): 完善'生产环境动态配置'步骤 (vbenjs#6297) fix: alert width fixed in small screen (vbenjs#6312) style: fix lint error (vbenjs#6298) feat: support for hybrid permission access control mode (vbenjs#6294) fix: fix table-title slot not work (vbenjs#6295) fix: Update index.ts (vbenjs#6268) fix: reset slider-captcha after login failed (vbenjs#6275) fix: json-bigint parse used in vxeTable (vbenjs#6271) fix: repair the unexpected form default value (vbenjs#5567) feat: optimize logo display (vbenjs#6267) feat: improve check updates (vbenjs#6257) feat: enhances compatibility with APIs returning large numeric values (vbenjs#6250) fix: component Input is not registered when initialize page (vbenjs#6246) feat: ellipsis text automatically displays tooltip based on ellipsis (vbenjs#6244) ... # Conflicts: # apps/web-naive/src/adapter/form.ts # apps/web-naive/src/bootstrap.ts # docs/src/components/common-ui/vben-ellipsis-text.md # docs/src/en/guide/in-depth/access.md # docs/src/guide/essentials/build.md # docs/src/guide/essentials/route.md
Description
完善 生产环境动态配置
Type of change
Please delete options that are not relevant.
Checklist
pnpm run docs:devcommand.pnpm test.feat:,fix:,perf:,docs:, orchore:.Summary by CodeRabbit