Skip to content

fix: add missing translation for preferences drawer #6094

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 1, 2025

Conversation

mynetfan
Copy link
Collaborator

@mynetfan mynetfan commented May 1, 2025

补全偏好设置抽屉的部分翻译内容。
fixed: #6084

Summary by CodeRabbit

  • New Features
    • Sidebar preference labels now support multiple languages with dynamic translations.
  • Documentation
    • Added new English and Chinese translations for sidebar button preferences.

Copy link

changeset-bot bot commented May 1, 2025

⚠️ No Changeset found

Latest commit: 94279c6

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link
Contributor

coderabbitai bot commented May 1, 2025

Walkthrough

The changes update the sidebar button configuration section in the preferences UI to support internationalization. Hardcoded Chinese labels within the Vue component are replaced with translation keys using the $t function. Corresponding English and Chinese translation strings are added to the localization files, enabling the sidebar button configuration text to be displayed in multiple languages. There are no changes to logic, data structures, or control flow.

Changes

Files Change Summary
packages/effects/layouts/src/widgets/preferences/blocks/layout/sidebar.vue Replaced hardcoded Chinese labels with $t translation keys for sidebar button configuration.
packages/locales/src/langs/en-US/preferences.json
packages/locales/src/langs/zh-CN/preferences.json
Added new translation keys for sidebar button configuration in both English and Chinese JSON files.

Assessment against linked issues

Objective Addressed Explanation
Sidebar button configuration in preferences supports internationalization (#6084)

Suggested reviewers

  • anncwb
  • jinmao88
  • vince292007

Poem

A hop and a skip, the sidebar's now wise,
With labels that shift for all language eyes.
No more hardcoding, just translate with glee—
Now "Fixed" and "Collapsed" speak globally!
🐇✨


📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 3e6d608 and 94279c6.

📒 Files selected for processing (3)
  • packages/effects/layouts/src/widgets/preferences/blocks/layout/sidebar.vue (1 hunks)
  • packages/locales/src/langs/en-US/preferences.json (1 hunks)
  • packages/locales/src/langs/zh-CN/preferences.json (1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms (8)
  • GitHub Check: Analyze (javascript-typescript)
  • GitHub Check: Check (windows-latest)
  • GitHub Check: Check (ubuntu-latest)
  • GitHub Check: Lint (ubuntu-latest)
  • GitHub Check: Test (windows-latest)
  • GitHub Check: Lint (windows-latest)
  • GitHub Check: post-update (windows-latest)
  • GitHub Check: post-update (ubuntu-latest)
🔇 Additional comments (4)
packages/locales/src/langs/zh-CN/preferences.json (1)

48-50: Added missing Chinese translations for sidebar button configuration.

Three new keys (buttons, buttonFixed, buttonCollapsed) under the sidebar section match the updated component labels. JSON syntax, indentation, and comma placement are correct.

packages/locales/src/langs/en-US/preferences.json (1)

48-50: Added missing English translations for sidebar button configuration.

The new keys (buttons, buttonFixed, buttonCollapsed) have been correctly inserted under the sidebar section with appropriate labels. File structure and JSON formatting look good.

packages/effects/layouts/src/widgets/preferences/blocks/layout/sidebar.vue (2)

82-83: Use dynamic translation keys for sidebar button options.

Replaced hardcoded Chinese labels with $t('preferences.sidebar.buttonCollapsed') and $t('preferences.sidebar.buttonFixed'). The value properties ('collapsed', 'fixed') align with the model logic in onMounted and handleCheckboxChange.


89-89: Use dynamic translation key for checkbox group label.

Replaced the static label with $t('preferences.sidebar.buttons'), matching the new localization entries.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@mynetfan mynetfan merged commit 0517a70 into vbenjs:main May 1, 2025
14 checks passed
@mynetfan mynetfan deleted the fix/preference-i18n branch May 1, 2025 12:08
@github-actions github-actions bot locked and limited conversation to collaborators Jun 1, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

偏好设置-侧边栏的按钮配置未实现国际化
1 participant