-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature: Entity Item Ref Extension #18265
Open
madsrasmussen
wants to merge
25
commits into
v15/dev
Choose a base branch
from
v15/feature/entity-item-ref-extension
base: v15/dev
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces a new extension point and a new element to render the extension "Entity Item Ref."
The extension point is used to render a list of references based on the "Item" model. The extension point will be used in pickers and reference lists where we, in some cases, can get a list of different entity types and therefore cannot hardcode the rendering of the list.
The item ref makes a lookup in the extension registry based on the "entity type" on the model and finds a matching extension. It is thereby possible to use a rendering specific to the type. If no matching extension can be found, it will use a default rendering.
The many changes is this PR is also caused be some item repositories/types being moved around
Here are some key areas to look at:
Manifest:
Using the element:
The PR implements the new umb-entity-item-ref element for three pickers as a test:
In addition, I have also aligned the UX of the pickers so they all support opening the workspace from the item and respect the section permissions.
What to test:
Please ensure that the pickers mentioned above work as expected.