fix: encoding and decoding of NativeScript #670
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There were 2 problems here: 1. The encoder would produce invalid CBOR in for the N-of-K variant of NativeScript which is encoded as an array of 3 elements, but marked as containing 2. 2. The decoder doesn't consume all the bytes it should; thus succeeding to decode partial / incomplete (and thus invalid) CBOR sequences. Note that while fixed in this particular instance for NativeScript, the problem is recurring across pretty much all list-like decoders within Pallas and should probably be subject to a larger overhaul.
KtorZ
commented
Jul 5, 2025
| e.encode_with(2, ctx)?; | ||
| e.encode_with(v, ctx)?; | ||
| } | ||
| NativeScript::ScriptNOfK(a, b) => { | ||
| e.array(3)?; |
KtorZ
commented
Jul 5, 2025
| let next = d.datatype()?; | ||
| if next != minicbor::data::Type::Break { | ||
| return Err(minicbor::decode::Error::type_mismatch(next)); | ||
| } |
scarmuega
approved these changes
Jul 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There were 2 problems here:
The encoder would produce invalid CBOR in for the N-of-K variant of NativeScript which is encoded as an array of 3 elements, but marked as containing 2.
The decoder doesn't consume all the bytes it should; thus succeeding to decode partial / incomplete (and thus invalid) CBOR sequences. Note that while fixed in this particular instance for NativeScript, the problem is recurring across pretty much all list-like decoders within Pallas and should probably be subject to a larger overhaul.