fix(frontend): prevent command menu reopening when clicking the same field #12390
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
There was a problem hiding this comment.
PR Summary
Implements a fix to prevent command menu from reopening when clicking the same record field, reducing unnecessary re-renders and scroll resets.
- Added early return in
useOpenRecordInCommandMenuby comparinglastRecordIdwith newrecordId - Added
data-record-idattribute to non-readonly cells inRecordTableCellBaseContainer - Enhanced
useListenClickOutsideto check record IDs in clicked element's parent chain - Improved click handling by preventing command menu closure when clicking within the same record
💡 (4/5) You can add custom instructions or style guidelines for the bot here!
3 file(s) reviewed, 3 comment(s)
Edit PR Review Bot Settings | Greptile
...les/object-record/record-table/record-table-cell/components/RecordTableCellBaseContainer.tsx
Outdated
Show resolved
Hide resolved
packages/twenty-front/src/modules/ui/utilities/pointer-event/hooks/useListenClickOutside.ts
Show resolved
Hide resolved
Comment on lines
+101
to
+103
| if (currentDataAttributes?.recordId === lastRecordId) { | ||
| return; | ||
| } |
There was a problem hiding this comment.
logic: Early return here could prevent other necessary click-outside behaviors. Consider moving this check to after other critical validations
|
🚀 Preview Environment Ready! Your preview environment is available at: http://bore.pub:2393 This environment will automatically shut down when the PR is closed or after 5 hours. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ressolve #12205
This PR fixes the issue where the record in the command menu was reopening when clicking the same field again.
https://github.com/user-attachments/assets/52da7b3f-4704-4a9c-8fc4-29534568b0c0
Added recordId to cells so it can be accessed when useListenClickOutside is triggered, and compared the previous recordId with the new one to prevent closing the command menu for the same record.
When the field is clicked, we compare the lastRecordId with the new recordId inside the openRecordInCommandMenu function to avoid reopening the menu unnecessarily.