adding new error codes to the temporary catch #12366
Conversation
|
🚀 Preview Environment Ready! Your preview environment is available at: http://bore.pub:49238 This environment will automatically shut down when the PR is closed or after 5 hours. |
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
There was a problem hiding this comment.
PR Summary
Enhanced error handling for Gmail and Microsoft messaging services by adding explicit handling of server-side error status codes (503, 502, 504, 509) as temporary errors.
- Added dedicated case for 503 status code in
/packages/twenty-server/src/modules/messaging/message-import-manager/drivers/gmail/utils/parse-gmail-messages-import-error.util.ts - Expanded Microsoft error handling in
/packages/twenty-server/src/modules/messaging/message-import-manager/drivers/microsoft/utils/parse-microsoft-messages-import.util.tsto include 503 and 509 status codes - Added handling for 'Authentication backend unavailable' errors with formatted messages for Gmail services
- Implemented consistent TEMPORARY_ERROR classification for server-side issues across both Gmail and Microsoft implementations
3 file(s) reviewed, 1 comment(s)
Edit PR Review Bot Settings | Greptile
...ging/message-import-manager/drivers/gmail/utils/parse-gmail-message-list-fetch-error.util.ts
Show resolved
Hide resolved
| if (errors?.[0]?.message.includes(`Authentication backend unavailable`)) { | ||
| return new MessageImportDriverException( | ||
| `${code} - ${reason} - ${message}`, | ||
| MessageImportDriverExceptionCode.TEMPORARY_ERROR, |
There was a problem hiding this comment.
as it will introduced to the team soon, error codes are now also used as a grouping criteria for CustomEceptions on sentry when present.
Here MessageImportDriverExceptionCode.TEMPORARY_ERROR is used multiple times for what seems to be different different errors. Maybe here it could be UNAVAILABLE_AUTH_ERROR for instance
For microsoft, examples of errors from the logs:
Fixes #12252