fix(workspace): simplify hostname matching logic in WorkspaceProvider… #12365
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…Effect Replaced `getHostnamesFromWorkspaceUrls` with `isWorkspaceHostnameMatchCurrentLocationHostname` for streamlined hostname comparison, reducing redundancy and improving logic clarity.
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
There was a problem hiding this comment.
PR Summary
This PR streamlines workspace URL redirection by simplifying hostname matching logic in the WorkspaceProviderEffect component, ensuring proper redirection to custom domains before sign-in.
- Introduced
isWorkspaceHostnameMatchCurrentLocationHostnameinpackages/twenty-front/src/modules/workspace/components/WorkspaceProviderEffect.tsxfor more efficient URL comparison - Remove debug
console.logstatement inWorkspaceProviderEffect.tsxbefore merging - Consider adding error handling for URL parsing in case of invalid workspace URLs
1 file(s) reviewed, 2 comment(s)
Edit PR Review Bot Settings | Greptile
packages/twenty-front/src/modules/workspace/components/WorkspaceProviderEffect.tsx
Outdated
Show resolved
Hide resolved
packages/twenty-front/src/modules/workspace/components/WorkspaceProviderEffect.tsx
Outdated
Show resolved
Hide resolved
|
🚀 Preview Environment Ready! Your preview environment is available at: http://bore.pub:9298 This environment will automatically shut down when the PR is closed or after 5 hours. |
…spaceProviderEffect
FelixMalfait
approved these changes
Jun 12, 2025
|
Let's make sure to test this well before deploy! |
naineel1209
pushed a commit
to naineel1209/twenty
that referenced
this pull request
Jun 12, 2025
twentyhq#12365) …Effect Replaced `getHostnamesFromWorkspaceUrls` with `isWorkspaceHostnameMatchCurrentLocationHostname` for streamlined hostname comparison, reducing redundancy and improving logic clarity. Fix twentyhq#12295
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…Effect
Replaced
getHostnamesFromWorkspaceUrlswithisWorkspaceHostnameMatchCurrentLocationHostnamefor streamlined hostname comparison, reducing redundancy and improving logic clarity.Fix #12295