Google-scopes-handling #12362
Open
Google-scopes-handling #12362
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tion to settings/account
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
There was a problem hiding this comment.
PR Summary
This PR enhances Google OAuth flow with improved scope management and error handling. The changes introduce a new GoogleAPIScopesService for validating OAuth permissions and better user experience.
- Added new
GoogleAPIScopesServicewith proper validation for Google OAuth scopes and fallback handling foruserinfoprefixes - Updated error redirect path from '/verify' to '/settings/accounts' in
google-apis-auth.controller.tsfor better UX - Added 600ms timeout for token info requests in
google-apis-scopes.tswhich might be too short for some network conditions - Added comprehensive test coverage in
google-apis-scopes.spec.tsbut missing tests forgetGoogleScopesmethod - Added documentation for special handling of 'email', 'profile', and 'openid' permissions without the full Google API prefix
7 file(s) reviewed, 4 comment(s)
Edit PR Review Bot Settings | Greptile
packages/twenty-server/src/engine/core-modules/auth/services/google-apis-scopes.spec.ts
Outdated
Show resolved
Hide resolved
packages/twenty-server/src/engine/core-modules/auth/services/google-apis-scopes.spec.ts
Outdated
Show resolved
Hide resolved
packages/twenty-server/src/engine/core-modules/auth/services/google-apis-scopes.ts
Show resolved
Hide resolved
packages/twenty-server/src/engine/core-modules/auth/services/google-apis.service.spec.ts
Outdated
Show resolved
Hide resolved
|
🚀 Preview Environment Ready! Your preview environment is available at: http://bore.pub:53532 This environment will automatically shut down when the PR is closed or after 5 hours. |
packages/twenty-server/src/engine/core-modules/auth/services/google-apis-scopes.spec.ts
Outdated
Show resolved
Hide resolved
packages/twenty-server/src/engine/core-modules/auth/services/google-apis-scopes.ts
Outdated
Show resolved
Hide resolved
packages/twenty-server/src/engine/core-modules/auth/services/google-apis-scopes.ts
Show resolved
Hide resolved
packages/twenty-server/src/engine/core-modules/auth/services/google-apis.service.ts
Outdated
Show resolved
Hide resolved
packages/twenty-server/src/engine/core-modules/auth/services/google-apis-scopes.ts
Outdated
Show resolved
Hide resolved
packages/twenty-server/src/engine/core-modules/auth/services/google-apis.service.ts
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Enhanced the Google OAuth flow to better handle missing permissions and improved user experience by redirecting to settings/account page.
Changes
User request
From @Bonapara email test and need to better handle user flow during the connect email flow
Before :
After :
Reference :
For google specialities, I added this link in the
export const getGoogleApisOauthScopesin order to keep that in mindhttps://developers.google.com/identity/protocols/oauth2/scopes