-
Notifications
You must be signed in to change notification settings - Fork 3.2k
Seed update - Replaced Qonto by Anthropic #12340
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
PR Summary
This PR replaces all references to Qonto with Anthropic across the codebase's test and mock data files, affecting company and person records.
- Updated company data in
standard-objects-prefill-data/company.ts
replacing Qonto with Anthropic (ID: f45ee421-8a3e-4aa5-a1cf-7207cc6754e1), including new address at 548 Market Street, SF and 1100 employees - Changed person data in
standard-objects-prefill-data/person.ts
replacing Alexandre Prot with Dario Amodei as Anthropic's representative - Inconsistent address data found between two Anthropic employee records in
people.ts
mock data - Inconsistent quote styles in company prefill data file need standardization
10 file(s) reviewed, 5 comment(s)
Edit PR Review Bot Settings | Greptile
@@ -72,8 +72,8 @@ export const SIGN_IN_BACKGROUND_MOCK_COMPANIES = [ | |||
createdAt: '2023-11-23T15:38:03.699Z', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
logic: createdAt date (2023) is inconsistent with updatedAt date (2024) for the same company
{ | ||
"nameFirstName": "Dario", | ||
"nameLastName": "Amodei", | ||
"city": "San Francisco", | ||
"emailsPrimaryEmail": "[email protected]", | ||
"avatarUrl": "https://twentyhq.github.io/placeholder-images/people/image-89.png", | ||
"position": 2, | ||
"createdBySource": FieldActorSource.SYSTEM, | ||
"createdByWorkspaceMemberId": null, | ||
"createdByName": "System", | ||
"phonesPrimaryPhoneNumber": "5551234567", | ||
"phonesPrimaryPhoneCountryCode": "+1", | ||
"companyId": ANTHROPIC_ID | ||
}, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
style: Inconsistent quote style (double quotes) compared to other records in the file which use single quotes
"createdByName": "System", | ||
"phonesPrimaryPhoneNumber": "5551234567", | ||
"phonesPrimaryPhoneCountryCode": "+1", | ||
"companyId": ANTHROPIC_ID |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
syntax: Missing comma after ANTHROPIC_ID to maintain consistency with other objects in the array
"companyId": ANTHROPIC_ID | |
"companyId": ANTHROPIC_ID, |
"id": ANTHROPIC_ID, | ||
"name": "Anthropic", | ||
"domainNamePrimaryLinkUrl": "https://anthropic.com", | ||
"addressAddressStreet1": "548 Market Street", | ||
"addressAddressStreet2": null, | ||
"addressAddressCity": "San Francisco", | ||
"addressAddressState": "CA", | ||
"addressAddressPostcode": "94104", | ||
"addressAddressCountry": "United States", | ||
"employees": 1100, | ||
"position": 2, | ||
"createdBySource": FieldActorSource.SYSTEM, | ||
"createdByWorkspaceMemberId": null, | ||
"createdByName": "System" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
style: Inconsistent quote style (double quotes) compared to other objects in the array (single quotes)
.createQueryBuilder(undefined, undefined, undefined, { | ||
shouldBypassPermissionChecks: true, | ||
}) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
style: Indentation is inconsistent with the rest of the chained methods
🚀 Preview Environment Ready! Your preview environment is available at: http://bore.pub:19867 This environment will automatically shut down when the PR is closed or after 5 hours. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tests need to be updated
No description provided.