Fix Client Config async loading #12308
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
There was a problem hiding this comment.
PR Summary
This PR fixes async loading issues in client configuration by ensuring proper loading state management and preventing race conditions in data fetching.
- Fixed race condition in
ClientConfigProviderEffect.tsxby movingisLoadedstate update after all client config data is loaded - Added loading check in
useGetPublicWorkspaceDataByDomain.tsto prevent premature API calls before client config is ready - Improved error handling in domain management to redirect to default domain on failures
- Reordered imports across multiple files for better code organization and maintainability
5 file(s) reviewed, no comment(s)
Edit PR Review Bot Settings | Greptile
Changes for performance improvement. The primary improvements include replacing GraphQL queries with REST-based client configuration fetching and making the client config non render-blocking
|
🚀 Preview Environment Ready! Your preview environment is available at: http://bore.pub:21365 This environment will automatically shut down when the PR is closed or after 5 hours. |
charlesBochet
commented
May 27, 2025
| @@ -0,0 +1,15 @@ | |||
| import { ClientConfig } from '~/generated/graphql'; | |||
|
|
|||
| let cachedClientConfig: ClientConfig | null = null; | |||
There was a problem hiding this comment.
still need to fix this :)
There was a problem hiding this comment.
why don't we use a recoilState here? we actually already have it
FelixMalfait
approved these changes
May 28, 2025
jordan-chalupka
pushed a commit
to InsurOS/twenty
that referenced
this pull request
May 28, 2025
Fix ClientConfig async loading --------- Co-authored-by: Félix Malfait <[email protected]> Co-authored-by: Félix Malfait <[email protected]>
abdulrahmancodes
pushed a commit
to abdulrahmancodes/twenty
that referenced
this pull request
Jun 2, 2025
Fix ClientConfig async loading --------- Co-authored-by: Félix Malfait <[email protected]> Co-authored-by: Félix Malfait <[email protected]>
abdulrahmancodes
pushed a commit
to abdulrahmancodes/twenty
that referenced
this pull request
Jun 2, 2025
Fix ClientConfig async loading --------- Co-authored-by: Félix Malfait <[email protected]> Co-authored-by: Félix Malfait <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix ClientConfig async loading