Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support PBXFileSystemSynchronizedGroupBuildPhaseMembershipExceptionSet #894

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

adincebic
Copy link

Resolves #838

Short description 📝

This PR is an update to the original one #874 I simply resolved conflicts since the original author is not responding.

NOTE: Please find all the reasoning in original pull request description.

Copy link
Collaborator

@kwridan kwridan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for helping complete this @adincebic

It's worth adding a new fixture or updating existing one to aid testing this

Running locally I see the comments generated don't quite match what Xcode expects and produces a diff 🙈

e.g.

 /* End PBXFileReference section */
 
 /* Begin PBXFileSystemSynchronizedBuildFileExceptionSet section */
-               FB5D38CD2D2E61BA00005FF8 /* Exceptions for "XC16SyncGroups" folder in "XC16SyncGroups" target */ = {
+               FB5D38CD2D2E61BA00005FF8 /* PBXFileSystemSynchronizedBuildFileExceptionSet */ = {
                        isa = PBXFileSystemSynchronizedBuildFileExceptionSet;
                        membershipExceptions = (
                                Foo.swift,
                        );
                        target = FB5D38AA2D2E618600005FF8 /* XC16SyncGroups */;
                };
-               FB5D38CE2D2E61BA00005FF8 /* Exceptions for "XC16SyncGroups" folder in "XC16SyncGroupsTests" target */ = {
+               FB5D38CE2D2E61BA00005FF8 /* PBXFileSystemSynchronizedBuildFileExceptionSet */ = {
                        isa = PBXFileSystemSynchronizedBuildFileExceptionSet;
                        membershipExceptions = (
                                Foo.swift,
@@ -42,8 +42,8 @@
                FB5D38AD2D2E618600005FF8 /* XC16SyncGroups */ = {
                        isa = PBXFileSystemSynchronizedRootGroup;
                        exceptions = (
-                               FB5D38CD2D2E61BA00005FF8 /* Exceptions for "XC16SyncGroups" folder in "XC16SyncGroups" target */,
-                               FB5D38CE2D2E61BA00005FF8 /* Exceptions for "XC16SyncGroups" folder in "XC16SyncGroupsTests" target */,
+                               FB5D38CD2D2E61BA00005FF8 /* PBXFileSystemSynchronizedBuildFileExceptionSet */,
+                               FB5D38CE2D2E61BA00005FF8 /* PBXFileSystemSynchronizedBuildFileExceptionSet */,
                        );
                        path = XC16SyncGroups;
                        sourceTree = "<group>";

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add support for Xcode 16's PBXFileSystemSynchronizedGroupBuildPhaseMembershipExceptionSet
3 participants