sort project references as xcode16 #867
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Speakus
changed the title
pepicrft
force-pushed
the
m.kholyavkin/IOSC-12423-sort-projectReferences-as-xcode16
branch
from
9459faf to
61391f4
Compare
pepicrft
requested changes
Dec 3, 2024
|
|
||
| for project in projects { | ||
| /// The project references are sorted alphabetically based on the name of the project it's being referenced. | ||
| project.projectReferences = project.projectReferences.sorted(by: { lhs, rhs in |
There was a problem hiding this comment.
@Speakus in which scenario a project contains more than one project reference. Would you mind adding a fixture under Fixtures so that we can add some tests?
There was a problem hiding this comment.
hi. I changed company where I work and It's not so easy for me anymore to provide some example.
@mikhailmulyar may you help with Fixtures?
There was a problem hiding this comment.
yes, will try to provide some example
There was a problem hiding this comment.
Here it is, I've added example with wrong ordering and some tests for checking.
mikhailmulyar@4f282f1
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Short description 📝
If project saved with XcodeProj then opening it with Xcode 16 generate some changes. So we could respect Xcode 16 sorting by sorting our result with the same way.
Solution 📦
Do the same sorting as Xcode 16 do
NB! This PR based on other fix so please merge this PR first #865